KAFKA-8306: Initialize log end offset accurately when start offset is non-zero#6652
Merged
Conversation
no log data exists.
ijuma
reviewed
Apr 30, 2019
| @@ -573,13 +573,13 @@ class Log(@volatile var dir: File, | |||
| if (logSegments.isEmpty) { | |||
| // no existing segments, create a new mutable segment beginning at offset 0 | |||
Member
There was a problem hiding this comment.
Seems like the comment needs to be updated.
hachikuji
reviewed
Apr 30, 2019
hachikuji
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch. I had one question.
hachikuji
reviewed
May 3, 2019
- Add a warning message when deleting segments.
hachikuji
approved these changes
May 3, 2019
hachikuji
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for the fix!
Contributor
Author
|
Failures look unrelated. Retest this please. |
hachikuji
pushed a commit
that referenced
this pull request
May 4, 2019
… non-zero (#6652) This patch ensures that the log end offset of each partition is initialized consistently with the checkpointed log start offset. Reviewers: Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io>
hachikuji
pushed a commit
that referenced
this pull request
May 4, 2019
… non-zero (#6652) This patch ensures that the log end offset of each partition is initialized consistently with the checkpointed log start offset. Reviewers: Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io>
hachikuji
pushed a commit
that referenced
this pull request
May 4, 2019
… non-zero (#6652) This patch ensures that the log end offset of each partition is initialized consistently with the checkpointed log start offset. Reviewers: Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io>
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
May 8, 2019
…s-hashcode * apache-github/trunk: KAFKA-8158: Add EntityType for Kafka RPC fields (apache#6503) MINOR: correctly parse version OffsetCommitResponse version < 3 KAFKA-8284: enable static membership on KStream (apache#6673) KAFKA-8304: Fix registration of Connect REST extensions (apache#6651) KAFKA-8275; Take throttling into account when choosing least loaded node (apache#6619) KAFKA-3522: Interactive Queries must return timestamped stores (apache#6661) MINOR: MetricsIntegrationTest should set StreamsConfig.STATE_DIR_CONFIG (apache#6687) MINOR: Remove unused field in `ListenerConnectionQuota` KAFKA-8131; Move --version implementation into CommandLineUtils (apache#6481) KAFKA-8056; Use automatic RPC generation for FindCoordinator (apache#6408) MINOR: Remove workarounds for lz4-java bug affecting byte buffers (apache#6679) KAFKA-7455: Support JmxTool to connect to a secured RMI port. (apache#5968) MINOR: Document improvement (apache#6682) MINOR: Fix ThrottledReplicaListValidator doc error. (apache#6537) KAFKA-8306; Initialize log end offset accurately when start offset is non-zero (apache#6652)
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
… non-zero (apache#6652) This patch ensures that the log end offset of each partition is initialized consistently with the checkpointed log start offset. Reviewers: Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.