feat(language-service): Quick fix to import a component when its selector is used#47088
Closed
dylhunn wants to merge 1 commit intoangular:mainfrom
Closed
feat(language-service): Quick fix to import a component when its selector is used#47088dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn wants to merge 1 commit intoangular:mainfrom
Conversation
0fa7567 to
2eb969b
Compare
atscott
requested changes
Aug 10, 2022
e854da9 to
d383f22
Compare
90853b7 to
e8250fc
Compare
e8250fc to
3046f95
Compare
beb4e2b to
35f6a9b
Compare
bd161ea to
d198966
Compare
1d09c07 to
bd9b144
Compare
ea053eb to
23c69d6
Compare
alxhub
approved these changes
Oct 7, 2022
632065e to
fd0fe22
Compare
ec90ac6 to
0e27ade
Compare
Contributor
Author
|
@alxhub I have applied fixes for all your comments, thanks! |
…ctor is used The language service can now generate an import corresponding to a selector. This includes both the TypeScript module import and the decorator import. This applies to both standalone components and components declared in NgModules.
0e27ade to
99fbd76
Compare
Contributor
|
This PR was merged into the repository by commit bebef5f. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The language service can now generate an import corresponding to a selector. This includes both the TypeScript module import and the decorator import. This applies to both standalone components and components declared in NgModules.
Previous PRs in this sequence:
Language Service: #47181
Compiler: #47180, #47166, #47561, #47631