refactor(compiler): Add a new helper method getOwningNgModule.#47166
Closed
dylhunn wants to merge 1 commit intoangular:mainfrom
Closed
refactor(compiler): Add a new helper method getOwningNgModule.#47166dylhunn wants to merge 1 commit intoangular:mainfrom
getOwningNgModule.#47166dylhunn wants to merge 1 commit intoangular:mainfrom
Conversation
b101e6a to
4fc9209
Compare
getPrimaryAngularDecorator and getOwningNgModulegetOwningNgModule().
4fc9209 to
9ed3b5b
Compare
getOwningNgModule().getOwningNgModule.
244a2b1 to
3df60ae
Compare
alxhub
approved these changes
Aug 18, 2022
Member
alxhub
left a comment
There was a problem hiding this comment.
As with the others, this shouldn't be a feat as it's not a public-facing feature of Angular.
3df60ae to
93aa93f
Compare
getOwningNgModule.getOwningNgModule.
93aa93f to
cea3b0b
Compare
cea3b0b to
07a1c86
Compare
Contributor
Author
|
Rebased. |
07a1c86 to
972bc52
Compare
972bc52 to
e8ccb63
Compare
This helper accepts a class for an Angular trait, and returns the NgModule which owns that trait. This will be useful for the language service import project, which needs to edit import arrays on the module.
e8ccb63 to
c884afb
Compare
Member
|
This PR was merged into the repository by commit edf7f67. |
alxhub
pushed a commit
that referenced
this pull request
Aug 22, 2022
) This helper accepts a class for an Angular trait, and returns the NgModule which owns that trait. This will be useful for the language service import project, which needs to edit import arrays on the module. PR Close #47166
alxhub
pushed a commit
that referenced
this pull request
Aug 22, 2022
) This helper accepts a class for an Angular trait, and returns the NgModule which owns that trait. This will be useful for the language service import project, which needs to edit import arrays on the module. PR Close #47166
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helper accepts a class for an Angular trait, and returns the NgModule which owns that trait. This will be useful for the language service import project, which needs to edit import arrays on the module.