refactor(compiler): Add getPotentialTemplateDirectives API method.#47561
Closed
dylhunn wants to merge 3 commits intoangular:mainfrom
Closed
refactor(compiler): Add getPotentialTemplateDirectives API method.#47561dylhunn wants to merge 3 commits intoangular:mainfrom
getPotentialTemplateDirectives API method.#47561dylhunn wants to merge 3 commits intoangular:mainfrom
Conversation
1ee7cef to
9d172b8
Compare
getPotentialTemplateDirectives and getPotentialImportsFor API methods.getPotentialTemplateDirectives API method.
5984ce5 to
b121aa4
Compare
b121aa4 to
efd0b2a
Compare
efd0b2a to
e8a1699
Compare
alxhub
requested changes
Oct 4, 2022
e8a1699 to
5a035cf
Compare
6d19174 to
0f28148
Compare
alxhub
approved these changes
Oct 4, 2022
a2a9cbb to
ff1273a
Compare
After implementing `getPotentialTemplateDirectives`, we will use this data struture to represent both in-scope and out-of-scope directives. So this rename is an advance cleanup.
`getPotentialTemplateDirectives` returns possible directives which can be used in the provided context, whether already in scope or requiring an import. This is necessary to implement auto-import support for standalone components in the language service.
Now that `getPotentialTemplateDirectives` uses `PotentialDirective`, we should rename `PipeInScope` to match.
ff1273a to
0362aad
Compare
Contributor
|
This PR was merged into the repository by commit 2919463. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 4, 2022
Now that `getPotentialTemplateDirectives` uses `PotentialDirective`, we should rename `PipeInScope` to match. PR Close #47561
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getPotentialTemplateDirectivesreturns possible directives which can be used in the provided context, whether already in scope or requiring an import.This is necessary to implement auto-import support for standalone components in the language service.
This is fourth in an ongoing sequence of PRs, including #47181, #47180, and #47166.