refactor(language-service): Create helper methods for manipulating object and array ASTs.#47181
Closed
dylhunn wants to merge 1 commit intoangular:mainfrom
Closed
refactor(language-service): Create helper methods for manipulating object and array ASTs.#47181dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn wants to merge 1 commit intoangular:mainfrom
Conversation
05d147b to
8bd0f56
Compare
8bd0f56 to
fed1be1
Compare
Contributor
Author
|
Andrew -- no pressure to review this, since I know you've got other stuff going on. Just adding you for visibility, in case you have opinions about these changes. |
alxhub
approved these changes
Aug 18, 2022
Member
alxhub
left a comment
There was a problem hiding this comment.
Important: this should be a refactor commit as it does not publicly expose a new feature.
…ject and array ASTs. Create three new helper methods: `addElementToArrayLiteral`, `objectPropertyAssignmentForKey`, and `updateObjectValueForKey`. These methods make interacting with array and object literals easier. These will be useful for the standalone imports feature, which will need to add new terms to import arrays in Component and NgModule decorators.
fed1be1 to
e42cda3
Compare
Member
|
This PR was merged into the repository by commit daac137. |
alxhub
pushed a commit
that referenced
this pull request
Aug 22, 2022
…ject and array ASTs. (#47181) Create three new helper methods: `addElementToArrayLiteral`, `objectPropertyAssignmentForKey`, and `updateObjectValueForKey`. These methods make interacting with array and object literals easier. These will be useful for the standalone imports feature, which will need to add new terms to import arrays in Component and NgModule decorators. PR Close #47181
alxhub
pushed a commit
that referenced
this pull request
Aug 22, 2022
…ject and array ASTs. (#47181) Create three new helper methods: `addElementToArrayLiteral`, `objectPropertyAssignmentForKey`, and `updateObjectValueForKey`. These methods make interacting with array and object literals easier. These will be useful for the standalone imports feature, which will need to add new terms to import arrays in Component and NgModule decorators. PR Close #47181
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create three new helper methods:
addElementToArrayLiteral,objectPropertyAssignmentForKey, andupdateObjectValueForKey. These methods make interacting with array and object literals easier.These will be useful for the standalone imports feature, which will need to add new terms to import arrays in Component and NgModule decorators.