Skip to content

refactor(compiler): Add getPotentialImportsFor method on template type checker#47631

Closed
dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn:new-compiler-apis-2
Closed

refactor(compiler): Add getPotentialImportsFor method on template type checker#47631
dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn:new-compiler-apis-2

Conversation

@dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Oct 5, 2022

getPotentialImportsFor returns an array of possible imports, including TypeScript module specifier and identifier name, for a requested trait in the context of a given component.

Previous PRs in this sequence: #47181, #47180, #47166, #47561

@dylhunn dylhunn added state: WIP area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release compiler: template type-checking labels Oct 5, 2022
@ngbot ngbot bot modified the milestone: Backlog Oct 5, 2022
@dylhunn dylhunn force-pushed the new-compiler-apis-2 branch 6 times, most recently from 71fdfcd to b002347 Compare October 5, 2022 01:28
@dylhunn dylhunn added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Oct 5, 2022
@dylhunn dylhunn requested a review from alxhub October 5, 2022 01:28
@dylhunn dylhunn marked this pull request as ready for review October 5, 2022 01:28
…ype checker

`getPotentialImportsFor` returns an array of possible imports, including TypeScript module specifier and identifier name, for a requested trait in the context of a given component.
@dylhunn dylhunn force-pushed the new-compiler-apis-2 branch from b002347 to cca4143 Compare October 5, 2022 18:13
@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Oct 5, 2022
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 8df8c77.

@dylhunn dylhunn deleted the new-compiler-apis-2 branch October 11, 2022 15:05
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler compiler: template type-checking target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants