🏗 Build and test AMP on Windows#29115
🏗 Build and test AMP on Windows#29115rsimha merged 8 commits intoampproject:masterfrom rsimha:2020-07-01-WindowsTesting
Conversation
|
|
|
Unblocked by ampproject/amp-closure-compiler#23 and #29903 |
|
This PR has sat around for more than a month while I've battled with various parts of the compilation toolchain. At long last, we have a fully working minified build on Windows, and fully working unit and integration tests on Edge. I'm sending this out for review so we can merge a blocking check for compilation on Windows and tests on Edge, and deal with IE test failures via a separate PR. Meanwhile, the current status on IE can be found in the PR description. (/cc @choumx) /cc @samouri who is looking to use this on a windows workstation. (Please check out this branch and let me know how it works for you.) |
kristoferbaxter
left a comment
There was a problem hiding this comment.
Looks good to me, but I am not on a Windows machine so would defer to someone who can take a look under Windows.
I've tested this PR on a Windows VM that I installed on my personal Mac computer. Based on that, and on multiple green Windows runs on GH Actions, I'm going to merge this. Happy to address other Windows inconsistencies / bugs in follow up PRs. |
|
We ran into |
|
@jaygray0919: can you open up an issue on the amp.dev repo? This issue is only about the amphtml one. FWIW, here are some items I've noticed about windows dev in the past week:
|
PR Highlights:
gulp distand builds minified AMP on Windows on GH actions (blocking check)Screenshots:
gulp diston Windows:...
gulp uniton Edge:gulp integrationon Edge:gulp integrationon IE 11:Future work: Fix tests on IE, make
build-system/more platform independentUnblocked by #28208
Follow up to #29012
Was blocked by #27570 (comment)
Unblocked by ampproject/amp-closure-compiler#23 plus other commits
Unblocked by #29903
Addresses #27520 (comment)
Fixes #27570