Skip to content

🏗✨ Initial configuration for cross-browser testing on Github Actions#29012

Merged
rsimha merged 5 commits intoampproject:masterfrom
rsimha:2020-06-22-GHActions
Jun 30, 2020
Merged

🏗✨ Initial configuration for cross-browser testing on Github Actions#29012
rsimha merged 5 commits intoampproject:masterfrom
rsimha:2020-06-22-GHActions

Conversation

@rsimha
Copy link
Copy Markdown
Contributor

@rsimha rsimha commented Jun 23, 2020 •
edited
Loading

This PR configures basic cross-browser testing on Github Actions. It is based on initial explorations done by @estherkim. Once this is reviewed and merged, we can enable GH Actions for amphtml and get some cross-browser testing going in non-blocking mode.

Highlights:

  • On Linux: unit and integration tests on Firefox
  • On MacOS: unit and integration tests on Safari

Coming up:

  • Merge this PR, pay for anticipated usage, and enable GH actions integration for amphtml
  • Skip / fix failing tests, and make the cross-browser tests apply a blocking status
  • After migration to native closure compiler, build and test AMP on Windows
  • Add more unit tests to the cross-browser workflow
  • Add more browsers (e.g. mobile Safari, Edge, IE)

Sample build: https://github.com/rsimha/amphtml/runs/801411834

@rsimha rsimha requested review from dreamofabear and estherkim June 23, 2020 23:42
@rsimha rsimha self-assigned this Jun 23, 2020
estherkim
estherkim reviewed Jun 24, 2020
View reviewed changes
@kristoferbaxter
Copy link
Copy Markdown
Contributor

kristoferbaxter commented Jun 26, 2020

This is quite exciting, thanks all for moving so quickly on it.

estherkim
estherkim reviewed Jun 26, 2020
View reviewed changes
@rsimha
Copy link
Copy Markdown
Contributor Author

rsimha commented Jun 29, 2020

All comments addressed. ready for a final look.

estherkim
estherkim reviewed Jun 29, 2020
View reviewed changes
rsimha
rsimha commented Jun 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All (excellent) comments addressed. Thanks for the careful review!

estherkim
estherkim approved these changes Jun 29, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@estherkim estherkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🥳

@rsimha rsimha merged commit 92e2105 into ampproject:master Jun 30, 2020
@rsimha rsimha deleted the 2020-06-22-GHActions branch June 30, 2020 03:32
This was referenced Jul 1, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estherkim estherkim estherkim approved these changes

@dreamofabear dreamofabear Awaiting requested review from dreamofabear

Assignees

@rsimha rsimha

Labels

cla: yes PR use: In Beta / Experimental WG: infra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rsimha @kristoferbaxter @dreamofabear @estherkim @googlebot @ampprojectbot