Skip to content
This repository was archived by the owner on Dec 10, 2021. It is now read-only.

Roll back to May's compiler, update publishing instructions, and add retry logic to auto-push#23

Merged
rsimha merged 2 commits intoampproject:masterfrom
rsimha:2020-08-18-MiscFixes
Aug 18, 2020
Merged

Roll back to May's compiler, update publishing instructions, and add retry logic to auto-push#23
rsimha merged 2 commits intoampproject:masterfrom
rsimha:2020-08-18-MiscFixes

Conversation

@rsimha
Copy link
Copy Markdown
Collaborator

@rsimha rsimha commented Aug 18, 2020

Highlights:

  • Roll back compiler version to 20200517.0.0 due to Compiling AMP code crashes July's closure compiler  #22
  • Update publishing instructions to push new tag to upstream, and consolidate publish actions
  • Fix bump-version.js to update all subpackages, not just the local one
  • Add retry logic to auto-pushes from GH actions to recover from a race between parallel jobs
  • Delete packages/google-closure-compiler/yarn.lock (it's only used during CI and shouldn't be checked in because it comes in the way of publishing)

image

@rsimha rsimha requested a review from kristoferbaxter August 18, 2020 21:06
@rsimha rsimha self-assigned this Aug 18, 2020
@rsimha rsimha merged commit 7a74ed2 into ampproject:master Aug 18, 2020
@rsimha rsimha deleted the 2020-08-18-MiscFixes branch August 18, 2020 22:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants