🐛 Remove the erroneous, trailing space in filename#27520
🐛 Remove the erroneous, trailing space in filename#27520kristoferbaxter merged 1 commit intoampproject:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Hey @erwinmombay, these files were changed: |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
bffae9e to
350e448
Compare
|
@kristoferbaxter it looks like this might have happened in a recent refactor. |
mdmower
left a comment
There was a problem hiding this comment.
This looks correct to me:
mdmower@X1 ~/source/amphtml $ ls -l build-system/babel-plugins/babel-plugin-transform-function-declarations/test/fixtures/transform-assertions/arguments-identifier/
total 12
-rw-r--r-- 1 mdmower mdmower 695 Apr 2 11:00 input.js
-rw-r--r-- 1 mdmower mdmower 80 Apr 2 11:00 'options.json '
-rw-r--r-- 1 mdmower mdmower 695 Apr 2 11:00 output.js
Hopefully an OWNER will review and accept soon. I hit a similar issue in amp-toolbox recently: ampproject/amp-toolbox#673
|
I kicked travis to restart. |
|
Apologies, just saw this. @rsimha - Can we get a Windows build check added to the environment via Github Actions? This would be a nice additional gate for our development and prevent future issues like this one. |
It's something we've talked about, but I'm not sure if we ever got to the point of trying it out. Can you file a FR under |
The
build-system\babel-plugins\babel-plugin-transform-function-declarations\test\fixtures\transform-assertions\arguments-identifier\options.jsonhad a trailing space in the file name that stopped the repo being cloned on a windows file system. This PR simply removes the space.