🐛 Pass through applicable AMP experiments to SwG#25512
Merged
alin04 merged 4 commits intoampproject:masterfrom Nov 12, 2019
Merged
🐛 Pass through applicable AMP experiments to SwG#25512alin04 merged 4 commits intoampproject:masterfrom
alin04 merged 4 commits intoampproject:masterfrom
Conversation
logic per experiment flag. Enable 'gpay-native' experiment to 100%. It will take effect as the 'gpay' experiment is ramped up.
jpettitt
reviewed
Nov 11, 2019
extensions/amp-subscriptions-google/0.1/amp-subscriptions-google.js
Outdated
Show resolved
Hide resolved
Only pass through experiments prefixed with 'swg-' from AMP to SwG.
jpettitt
approved these changes
Nov 12, 2019
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* Pass through all AMP experiments to SwG, so we don't need individual logic per experiment flag. Enable 'gpay-native' experiment to 100%. It will take effect as the 'gpay' experiment is ramped up. * Only pass through swg experiments from AMP. Only pass through experiments prefixed with 'swg-' from AMP to SwG. * Fix lint issue. * Fix lint issue with startsWith.
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 4, 2020
prod-config.json history: 31f7e22 - 2019-11-12T09:11:14-08:00 🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 4, 2020
Config last modified up to 2019-12-06T08:00:09.679Z: - (ampproject#17012) `amp-access-iframe` (on) - (ampproject#24810) `amp-action-macro` (on) - (ampproject#25480) `amp-mega-menu` (on) - (ampproject#25516) `amp-nested-menu` (on) - (ampproject#7403) `amp-playbuzz` (on) - (ampproject#25170) `amp-sidebar-swipe-to-dismiss` (on) - (ampproject#19140) `amp-story-responsive-units` (on) - (ampproject#16678) `amp-story-v1` (on) - (ampproject#16678) `chunked-amp` (on) - (ampproject#25269) `fix-inconsistent-responsive-height-selection` (off) - (ampproject#21058) `fixed-elements-in-lightbox` (on) - (ampproject#9298) `pump-early-frame` (on) - (ampproject#25512) `swg-gpay-native` (on)⚠️ **This changes Javascript source files** The following may contain errors, and require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 4, 2020
prod-config.json history: - 31f7e22 - 2019-11-12T09:11:14-08:00 🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 4, 2020
Sweep experiments last flipped globally up to 2019-12-06T08:00:02.356Z: - (ampproject#17012) `amp-access-iframe` (on) - (ampproject#24810) `amp-action-macro` (on) - (ampproject#25480) `amp-mega-menu` (on) - (ampproject#25516) `amp-nested-menu` (on) - (ampproject#7403) `amp-playbuzz` (on) - (ampproject#25170) `amp-sidebar-swipe-to-dismiss` (on) - (ampproject#19140) `amp-story-responsive-units` (on) - (ampproject#16678) `amp-story-v1` (on) - (ampproject#16678) `chunked-amp` (on) - (ampproject#25269) `fix-inconsistent-responsive-height-selection` (off) - (ampproject#21058) `fixed-elements-in-lightbox` (on) - (ampproject#9298) `pump-early-frame` (on) - (ampproject#25512) `swg-gpay-native` (on) --- **⚠️ This changes Javascript source files** The following may contain errors, and require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 31f7e22 - 2019-11-12T09:11:14-08:00 🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-06T08:00:26.122Z: - (ampproject#17012) `amp-access-iframe` (on) - (ampproject#24810) `amp-action-macro` (on) - (ampproject#25480) `amp-mega-menu` (on) - (ampproject#25516) `amp-nested-menu` (on) - (ampproject#7403) `amp-playbuzz` (on) - (ampproject#25170) `amp-sidebar-swipe-to-dismiss` (on) - (ampproject#19140) `amp-story-responsive-units` (on) - (ampproject#16678) `amp-story-v1` (on) - (ampproject#16678) `chunked-amp` (on) - (ampproject#25269) `fix-inconsistent-responsive-height-selection` (off) - (ampproject#21058) `fixed-elements-in-lightbox` (on) - (ampproject#9298) `pump-early-frame` (on) - (ampproject#25512) `swg-gpay-native` (on) --- **⚠️ This changes Javascript source files** The following may contain errors, and require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 31f7e22 - 2019-11-12T09:11:14-08:00 🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-06: - (2019-10-01, ampproject#24810) amp-action-macro: 1 - (2018-11-05, ampproject#19140) amp-story-responsive-units: 1 - (2018-07-11, ampproject#16678) amp-story-v1: 1 - (2018-07-11, ampproject#16678) chunked-amp: 1 - (2019-10-28, ampproject#25269) fix-inconsistent-responsive-height-selection: 0 - (2017-05-16, ampproject#9298) pump-early-frame: 1 - (2019-11-12, ampproject#25512) swg-gpay-native: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 31f7e22 - 2019-11-12T09:11:14-08:00 🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-06: - (2018-07-23, ampproject#17012) amp-access-iframe: 1 - (2019-10-01, ampproject#24810) amp-action-macro: 1 - (2019-11-08, ampproject#25480) amp-mega-menu: 1 - (2019-11-13, ampproject#25516) amp-nested-menu: 1 - (2017-02-07, ampproject#7403) amp-playbuzz: 1 - (2019-10-21, ampproject#25170) amp-sidebar-swipe-to-dismiss: 1 - (2018-11-05, ampproject#19140) amp-story-responsive-units: 1 - (2018-07-11, ampproject#16678) amp-story-v1: 1 - (2018-07-11, ampproject#16678) chunked-amp: 1 - (2019-10-28, ampproject#25269) fix-inconsistent-responsive-height-selection: 0 - (2019-02-26, ampproject#21058) fixed-elements-in-lightbox: 1 - (2017-05-16, ampproject#9298) pump-early-frame: 1 - (2019-11-12, ampproject#25512) swg-gpay-native: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 31f7e22 - 2019-11-12T09:11:14-08:00 🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-06: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 31f7e22 - 2019-11-12T09:11:14-08:00 🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-04: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 31f7e22 - 2019-11-12T09:11:14-08:00 🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-04: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 31f7e22 - 2019-11-12T09:11:14-08:00 🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-04: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 31f7e22 - 2019-11-12T09:11:14-08:00 🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-04: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 31f7e22 - 2019-11-12T09:11:14-08:00 🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-05: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js` --- **⚠️ There are HTML files with possible references** The following HTML files contain references to experiment names which may be stale and should be manually removed: - `examples/playbuzz.amp.html` - `examples/responsive-menu.amp.html` - `examples/visual-tests/amp-mega-menu/amp-mega-menu.amp.html` - `examples/visual-tests/amp-mega-menu/amp-mega-menu-with-list.amp.html` - `examples/amp-action-macro.html` - `test/manual/amp-mega-menu/amp-mega-menu.amp.html` - `test/manual/amp-mega-menu/amp-mega-menu-with-list.amp.html`
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
…on history:\n\n - 31f7e22 - 2019-11-12T09:11:14-08:00\n 🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)\n
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
…lipped globally up to 2019-12-05:\n\n- (2018-07-23, ampproject#17012) `amp-access-iframe`: 1\n- (2019-10-01, ampproject#24810) `amp-action-macro`: 1\n- (2019-11-08, ampproject#25480) `amp-mega-menu`: 1\n- (2019-11-13, ampproject#25516) `amp-nested-menu`: 1\n- (2017-02-07, ampproject#7403) `amp-playbuzz`: 1\n- (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1\n- (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1\n- (2018-07-11, ampproject#16678) `amp-story-v1`: 1\n- (2018-07-11, ampproject#16678) `chunked-amp`: 1\n- (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0\n- (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1\n- (2017-05-16, ampproject#9298) `pump-early-frame`: 1\n- (2019-11-12, ampproject#25512) `swg-gpay-native`: 1\n\n---\n\n**⚠️ This changes Javascript source files**\n\nThe following may contain errors and/or require intervention to remove superfluous conditionals:\n\n- `extensions/amp-access/0.1/amp-access-source.js`\n- `extensions/amp-access/0.1/test/test-amp-access-source.js`\n- `extensions/amp-action-macro/0.1/amp-action-macro.js`\n- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`\n- `extensions/amp-playbuzz/0.1/amp-playbuzz.js`\n- `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js`\n- `extensions/amp-sidebar/0.1/amp-sidebar.js`\n- `extensions/amp-sidebar/0.2/amp-sidebar.js`\n- `extensions/amp-story/1.0/amp-story.js`\n- `extensions/amp-story/1.0/test/test-amp-story.js`\n- `src/runtime.js`\n- `test/unit/test-runtime.js`\n\n---\n\n**⚠️ There are HTML files with possible references**\n\nThe following HTML files contain references to experiment names which may be stale and should be manually removed:\n\n- `examples/playbuzz.amp.html`\n- `examples/responsive-menu.amp.html`\n- `examples/amp-action-macro.html`\n- `examples/visual-tests/amp-mega-menu/amp-mega-menu-with-list.amp.html`\n- `examples/visual-tests/amp-mega-menu/amp-mega-menu.amp.html`\n- `test/manual/amp-mega-menu/amp-mega-menu-with-list.amp.html`\n- `test/manual/amp-mega-menu/amp-mega-menu.amp.html`\n\n
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 31f7e22 - 2019-11-12T09:11:14-08:00 🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-05: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js` --- **⚠️ There are HTML files with possible references** The following HTML files contain references to experiment names which may be stale and should be manually removed: - `examples/playbuzz.amp.html` - `examples/responsive-menu.amp.html` - `examples/amp-action-macro.html` - `examples/visual-tests/amp-mega-menu/amp-mega-menu-with-list.amp.html` - `examples/visual-tests/amp-mega-menu/amp-mega-menu.amp.html` - `test/manual/amp-mega-menu/amp-mega-menu-with-list.amp.html` - `test/manual/amp-mega-menu/amp-mega-menu.amp.html`
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 31f7e22 - 2019-11-12T09:11:14-08:00 🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-05: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js` --- **⚠️ There are HTML files with possible references** The following HTML files contain references to experiment names which may be stale and should be manually removed: - `examples/playbuzz.amp.html` - `examples/responsive-menu.amp.html` - `examples/amp-action-macro.html` - `examples/visual-tests/amp-mega-menu/amp-mega-menu-with-list.amp.html` - `examples/visual-tests/amp-mega-menu/amp-mega-menu.amp.html` - `test/manual/amp-mega-menu/amp-mega-menu-with-list.amp.html` - `test/manual/amp-mega-menu/amp-mega-menu.amp.html`
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 6, 2020
Previous history on prod-config.json: - 31f7e22 - 2019-11-12T09:11:14-08:00 - 🐛,Pass,through,applicable,AMP,experiments,to,SwG,(ampproject#25512)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 6, 2020
Previous history on prod-config.json: - 31f7e22 - 2019-11-12T09:11:14-08:00 - 🐛,Pass,through,applicable,AMP,experiments,to,SwG,(ampproject#25512)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 31f7e22 - 2019-11-12T09:11:14-08:00 - 🐛,Pass,through,applicable,AMP,experiments,to,SwG,(ampproject#25512)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 31f7e22 - 2019-11-12T09:11:14-08:00 - 🐛 Pass through applicable AMP experiments to SwG (ampproject#25512)
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
- (ampproject#17012) `amp-access-iframe` (cleanup issue ampproject#13287) - (ampproject#25480) `amp-mega-menu` - (ampproject#25516) `amp-nested-menu` - (ampproject#6947) `amp-playbuzz` (cleanup issue ampproject#6351) - (ampproject#25170) `amp-sidebar-swipe-to-dismiss` - (ampproject#21058) `fixed-elements-in-lightbox` - (ampproject#25512) `swg-gpay-native` - (ampproject#26021) `swg-gpay-api`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass through all AMP experiments to SwG, so we don't need individual
logic per experiment flag. Enable 'gpay-native' experiment to 100%. It
will take effect as the 'gpay' experiment is ramped up.
This does mean that AMP and SwG share experiment namespaces now.