Launch <amp-action-macro> by alabiaga · Pull Request #24810 · ampproject/amphtml

alabiaga · 2019-09-30T15:36:45Z

dreamofabear · 2019-09-30T19:07:27Z

tools/experiments/experiments.js

-    name: 'AMP extension for defining action macros',
-    spec: 'https://github.com/ampproject/amphtml/issues/19494',
-    cleanupIssue: 'https://github.com/ampproject/amphtml/pull/19495',
-  },


This just removes it from the list on the experiments page. To actually launch the extension, you have to add "amp-action-macro: 1 to prod-config.json and canary-config.json. I'd revert this change.

done. thanks

dreamofabear · 2019-09-30T21:11:54Z

/to @ampproject/wg-approvers Seeking approval for a new extension launch. Documentation here: https://github.com/ampproject/amphtml/blob/master/extensions/amp-action-macro/amp-action-macro.md

dreamofabear

We should also remove the "experimental" status from amp-action-macro.md.

cramforce · 2019-09-30T21:13:53Z

Oh, this hasn't launched? I have no objections.

alabiaga · 2019-10-01T14:32:32Z

@choumx Thanks Will

prod-config.json history: 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

Config last modified up to 2019-12-06T08:00:09.679Z: - (ampproject#17012) `amp-access-iframe` (on) - (ampproject#24810) `amp-action-macro` (on) - (ampproject#25480) `amp-mega-menu` (on) - (ampproject#25516) `amp-nested-menu` (on) - (ampproject#7403) `amp-playbuzz` (on) - (ampproject#25170) `amp-sidebar-swipe-to-dismiss` (on) - (ampproject#19140) `amp-story-responsive-units` (on) - (ampproject#16678) `amp-story-v1` (on) - (ampproject#16678) `chunked-amp` (on) - (ampproject#25269) `fix-inconsistent-responsive-height-selection` (off) - (ampproject#21058) `fixed-elements-in-lightbox` (on) - (ampproject#9298) `pump-early-frame` (on) - (ampproject#25512) `swg-gpay-native` (on)⚠️ **This changes Javascript source files** The following may contain errors, and require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

Sweep experiments last flipped globally up to 2019-12-06T08:00:02.356Z: - (ampproject#17012) `amp-access-iframe` (on) - (ampproject#24810) `amp-action-macro` (on) - (ampproject#25480) `amp-mega-menu` (on) - (ampproject#25516) `amp-nested-menu` (on) - (ampproject#7403) `amp-playbuzz` (on) - (ampproject#25170) `amp-sidebar-swipe-to-dismiss` (on) - (ampproject#19140) `amp-story-responsive-units` (on) - (ampproject#16678) `amp-story-v1` (on) - (ampproject#16678) `chunked-amp` (on) - (ampproject#25269) `fix-inconsistent-responsive-height-selection` (off) - (ampproject#21058) `fixed-elements-in-lightbox` (on) - (ampproject#9298) `pump-early-frame` (on) - (ampproject#25512) `swg-gpay-native` (on) --- **⚠️ This changes Javascript source files** The following may contain errors, and require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

Sweep experiments last flipped globally up to 2019-12-06T08:00:26.122Z: - (ampproject#17012) `amp-access-iframe` (on) - (ampproject#24810) `amp-action-macro` (on) - (ampproject#25480) `amp-mega-menu` (on) - (ampproject#25516) `amp-nested-menu` (on) - (ampproject#7403) `amp-playbuzz` (on) - (ampproject#25170) `amp-sidebar-swipe-to-dismiss` (on) - (ampproject#19140) `amp-story-responsive-units` (on) - (ampproject#16678) `amp-story-v1` (on) - (ampproject#16678) `chunked-amp` (on) - (ampproject#25269) `fix-inconsistent-responsive-height-selection` (off) - (ampproject#21058) `fixed-elements-in-lightbox` (on) - (ampproject#9298) `pump-early-frame` (on) - (ampproject#25512) `swg-gpay-native` (on) --- **⚠️ This changes Javascript source files** The following may contain errors, and require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

Sweep experiments last flipped globally up to 2019-12-06: - (2019-10-01, ampproject#24810) amp-action-macro: 1 - (2018-11-05, ampproject#19140) amp-story-responsive-units: 1 - (2018-07-11, ampproject#16678) amp-story-v1: 1 - (2018-07-11, ampproject#16678) chunked-amp: 1 - (2019-10-28, ampproject#25269) fix-inconsistent-responsive-height-selection: 0 - (2017-05-16, ampproject#9298) pump-early-frame: 1 - (2019-11-12, ampproject#25512) swg-gpay-native: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

Sweep experiments last flipped globally up to 2019-12-06: - (2018-07-23, ampproject#17012) amp-access-iframe: 1 - (2019-10-01, ampproject#24810) amp-action-macro: 1 - (2019-11-08, ampproject#25480) amp-mega-menu: 1 - (2019-11-13, ampproject#25516) amp-nested-menu: 1 - (2017-02-07, ampproject#7403) amp-playbuzz: 1 - (2019-10-21, ampproject#25170) amp-sidebar-swipe-to-dismiss: 1 - (2018-11-05, ampproject#19140) amp-story-responsive-units: 1 - (2018-07-11, ampproject#16678) amp-story-v1: 1 - (2018-07-11, ampproject#16678) chunked-amp: 1 - (2019-10-28, ampproject#25269) fix-inconsistent-responsive-height-selection: 0 - (2019-02-26, ampproject#21058) fixed-elements-in-lightbox: 1 - (2017-05-16, ampproject#9298) pump-early-frame: 1 - (2019-11-12, ampproject#25512) swg-gpay-native: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

Sweep experiments last flipped globally up to 2019-12-06: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

Sweep experiments last flipped globally up to 2019-12-04: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

Sweep experiments last flipped globally up to 2019-12-04: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

Sweep experiments last flipped globally up to 2019-12-04: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

Sweep experiments last flipped globally up to 2019-12-04: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js`

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

Sweep experiments last flipped globally up to 2019-12-05: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js` --- **⚠️ There are HTML files with possible references** The following HTML files contain references to experiment names which may be stale and should be manually removed: - `examples/playbuzz.amp.html` - `examples/responsive-menu.amp.html` - `examples/visual-tests/amp-mega-menu/amp-mega-menu.amp.html` - `examples/visual-tests/amp-mega-menu/amp-mega-menu-with-list.amp.html` - `examples/amp-action-macro.html` - `test/manual/amp-mega-menu/amp-mega-menu.amp.html` - `test/manual/amp-mega-menu/amp-mega-menu-with-list.amp.html`

…son history:\n\n - 0ab715e - 2019-10-01T10:32:36-04:00\n Launch <amp-action-macro> (ampproject#24810)\n

…lipped globally up to 2019-12-05:\n\n- (2018-07-23, ampproject#17012) `amp-access-iframe`: 1\n- (2019-10-01, ampproject#24810) `amp-action-macro`: 1\n- (2019-11-08, ampproject#25480) `amp-mega-menu`: 1\n- (2019-11-13, ampproject#25516) `amp-nested-menu`: 1\n- (2017-02-07, ampproject#7403) `amp-playbuzz`: 1\n- (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1\n- (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1\n- (2018-07-11, ampproject#16678) `amp-story-v1`: 1\n- (2018-07-11, ampproject#16678) `chunked-amp`: 1\n- (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0\n- (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1\n- (2017-05-16, ampproject#9298) `pump-early-frame`: 1\n- (2019-11-12, ampproject#25512) `swg-gpay-native`: 1\n\n---\n\n**⚠️ This changes Javascript source files**\n\nThe following may contain errors and/or require intervention to remove superfluous conditionals:\n\n- `extensions/amp-access/0.1/amp-access-source.js`\n- `extensions/amp-access/0.1/test/test-amp-access-source.js`\n- `extensions/amp-action-macro/0.1/amp-action-macro.js`\n- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`\n- `extensions/amp-playbuzz/0.1/amp-playbuzz.js`\n- `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js`\n- `extensions/amp-sidebar/0.1/amp-sidebar.js`\n- `extensions/amp-sidebar/0.2/amp-sidebar.js`\n- `extensions/amp-story/1.0/amp-story.js`\n- `extensions/amp-story/1.0/test/test-amp-story.js`\n- `src/runtime.js`\n- `test/unit/test-runtime.js`\n\n---\n\n**⚠️ There are HTML files with possible references**\n\nThe following HTML files contain references to experiment names which may be stale and should be manually removed:\n\n- `examples/playbuzz.amp.html`\n- `examples/responsive-menu.amp.html`\n- `examples/amp-action-macro.html`\n- `examples/visual-tests/amp-mega-menu/amp-mega-menu-with-list.amp.html`\n- `examples/visual-tests/amp-mega-menu/amp-mega-menu.amp.html`\n- `test/manual/amp-mega-menu/amp-mega-menu-with-list.amp.html`\n- `test/manual/amp-mega-menu/amp-mega-menu.amp.html`\n\n

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

Sweep experiments last flipped globally up to 2019-12-05: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js` --- **⚠️ There are HTML files with possible references** The following HTML files contain references to experiment names which may be stale and should be manually removed: - `examples/playbuzz.amp.html` - `examples/responsive-menu.amp.html` - `examples/amp-action-macro.html` - `examples/visual-tests/amp-mega-menu/amp-mega-menu-with-list.amp.html` - `examples/visual-tests/amp-mega-menu/amp-mega-menu.amp.html` - `test/manual/amp-mega-menu/amp-mega-menu-with-list.amp.html` - `test/manual/amp-mega-menu/amp-mega-menu.amp.html`

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

Sweep experiments last flipped globally up to 2019-12-05: - (2018-07-23, ampproject#17012) `amp-access-iframe`: 1 - (2019-10-01, ampproject#24810) `amp-action-macro`: 1 - (2019-11-08, ampproject#25480) `amp-mega-menu`: 1 - (2019-11-13, ampproject#25516) `amp-nested-menu`: 1 - (2017-02-07, ampproject#7403) `amp-playbuzz`: 1 - (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1 - (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1 - (2018-07-11, ampproject#16678) `amp-story-v1`: 1 - (2018-07-11, ampproject#16678) `chunked-amp`: 1 - (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0 - (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1 - (2017-05-16, ampproject#9298) `pump-early-frame`: 1 - (2019-11-12, ampproject#25512) `swg-gpay-native`: 1 --- **⚠️ This changes Javascript source files** The following may contain errors and/or require intervention to remove superfluous conditionals: - `extensions/amp-access/0.1/amp-access-source.js` - `extensions/amp-access/0.1/test/test-amp-access-source.js` - `extensions/amp-action-macro/0.1/amp-action-macro.js` - `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js` - `extensions/amp-playbuzz/0.1/amp-playbuzz.js` - `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js` - `extensions/amp-sidebar/0.1/amp-sidebar.js` - `extensions/amp-sidebar/0.2/amp-sidebar.js` - `extensions/amp-story/1.0/amp-story.js` - `extensions/amp-story/1.0/test/test-amp-story.js` - `src/runtime.js` - `test/unit/test-runtime.js` --- **⚠️ There are HTML files with possible references** The following HTML files contain references to experiment names which may be stale and should be manually removed: - `examples/playbuzz.amp.html` - `examples/responsive-menu.amp.html` - `examples/amp-action-macro.html` - `examples/visual-tests/amp-mega-menu/amp-mega-menu-with-list.amp.html` - `examples/visual-tests/amp-mega-menu/amp-mega-menu.amp.html` - `test/manual/amp-mega-menu/amp-mega-menu-with-list.amp.html` - `test/manual/amp-mega-menu/amp-mega-menu.amp.html`

Previous history on prod-config.json: - 0ab715e - 2019-10-01T10:32:36-04:00 - Launch,<amp-action-macro>,(ampproject#24810)

Previous history on prod-config.json: - 0ab715e - 2019-10-01T10:32:36-04:00 - Launch <amp-action-macro> (ampproject#24810)

msoo14131 · 2024-08-04T15:39:38Z

build-system/global-configs/prod-config.json


  "a4aProfilingRate": 0.01,
  "amp-access-iframe": 1,
+  "amp-action-macro": 1,


msoo14131

name: _
publish_to: none
environment:
sdk: ^3.6.0
workspace:

packages/helper
packages/client_package
packages/server_package

remove from experiment

79a9681

googlebot added the cla: yes label Sep 30, 2019

amp-owners-bot bot requested a review from rsimha September 30, 2019 15:36

alabiaga requested a review from dreamofabear September 30, 2019 16:16

dreamofabear requested changes Sep 30, 2019

View reviewed changes

alabiaga added 3 commits September 30, 2019 15:28

update prod config

95e8425

update canary config

59d790d

revert amp-action-macro experiment

b0dcc25

dreamofabear changed the title ~~Remove amp-action-macro from experiment~~ Launch <amp-action-macro> Sep 30, 2019

dreamofabear reviewed Sep 30, 2019

View reviewed changes

remove experimental text

4077623

dreamofabear approved these changes Oct 1, 2019

View reviewed changes

alabiaga merged commit 0ab715e into master Oct 1, 2019

alabiaga mentioned this pull request Oct 1, 2019

Remove amp-action-macro experiment. #19495

Closed

rsimha deleted the amp-action-macro-experiment-removal branch February 13, 2020 22:44

alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 4, 2020

amp-action-macro (ampproject#24810)

f7ee707

prod-config.json history: 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 4, 2020

amp-action-macro (ampproject#24810)

5f8e59f

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

samouri mentioned this pull request Dec 4, 2020

🚮 Launched experiment sweep #31438

Merged

alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020

amp-action-macro (ampproject#24810)

77953b2

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020

(2019-10-01, ampproject#24810) amp-action-macro: 1

5b90792

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020

(2019-10-01, ampproject#24810) amp-action-macro: 1

a8cafd2

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020

(2019-10-01, ampproject#24810) amp-action-macro: 1

be0c184

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

alanorozco mentioned this pull request Dec 5, 2020

🚮 Sweep experiments (demo) #31457

Closed

alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020

(2019-10-01, ampproject#24810) amp-action-macro: 1

816d5fb

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

alanorozco mentioned this pull request Dec 5, 2020

🚮 Sweep experiments (demo) #31459

Closed

alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020

(2019-10-01, ampproject#24810) amp-action-macro: 1

39fe612

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

alanorozco mentioned this pull request Dec 5, 2020

🚮 Sweep experiments (demo) #31460

Closed

alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020

(2019-10-01, ampproject#24810) amp-action-macro: 1

38d43ba

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020

(2019-10-01, ampproject#24810) amp-action-macro: 1

3217aca

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

alanorozco mentioned this pull request Dec 5, 2020

🚮 Sweep experiments (demo) #31461

Closed

alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020

(2019-10-01, ampproject#24810) amp-action-macro: 1

e2cafe6

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020

(2019-10-01, ampproject#24810) amp-action-macro: 1\n\nprod-config.j…

1922b71

…son history:\n\n - 0ab715e - 2019-10-01T10:32:36-04:00\n Launch <amp-action-macro> (ampproject#24810)\n

github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020

(2019-10-01, ampproject#24810) amp-action-macro: 1

e75b773

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020

(2019-10-01, ampproject#24810) amp-action-macro: 1

6d0affa

prod-config.json history: - 0ab715e - 2019-10-01T10:32:36-04:00 Launch <amp-action-macro> (ampproject#24810)

github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 6, 2020

(2019-10-01, 0ab715e) amp-action-macro: 1

57a9c5b

Previous history on prod-config.json: - 0ab715e - 2019-10-01T10:32:36-04:00 - Launch,<amp-action-macro>,(ampproject#24810)

github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 6, 2020

(2019-10-01, 0ab715e) amp-action-macro: 1

881070c

Previous history on prod-config.json: - 0ab715e - 2019-10-01T10:32:36-04:00 - Launch,<amp-action-macro>,(ampproject#24810)

github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 7, 2020

(2019-10-01, 0ab715e) amp-action-macro: 1

917f1c0

Previous history on prod-config.json: - 0ab715e - 2019-10-01T10:32:36-04:00 - Launch,<amp-action-macro>,(ampproject#24810)

alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 7, 2020

(2019-10-01, 0ab715e) amp-action-macro: 1

819c9a0

Previous history on prod-config.json: - 0ab715e - 2019-10-01T10:32:36-04:00 - Launch <amp-action-macro> (ampproject#24810)

msoo14131 reviewed Aug 4, 2024

View reviewed changes

build-system/global-configs/prod-config.json

"a4aProfilingRate": 0.01,

"amp-access-iframe": 1,

"amp-action-macro": 1,

Copy link
Copy Markdown

msoo14131 Aug 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

23

msoo14131 reviewed May 26, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Launch <amp-action-macro>#24810

Launch <amp-action-macro>#24810
alabiaga merged 5 commits intomasterfrom
amp-action-macro-experiment-removal

alabiaga commented Sep 30, 2019

Uh oh!

dreamofabear Sep 30, 2019

Uh oh!

alabiaga Sep 30, 2019

Uh oh!

dreamofabear commented Sep 30, 2019

Uh oh!

dreamofabear left a comment

Uh oh!

cramforce commented Sep 30, 2019

Uh oh!

alabiaga commented Oct 1, 2019

Uh oh!

msoo14131 Aug 4, 2024

Uh oh!

msoo14131 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

alabiaga commented Sep 30, 2019

Uh oh!

dreamofabear Sep 30, 2019

Choose a reason for hiding this comment

Uh oh!

alabiaga Sep 30, 2019

Choose a reason for hiding this comment

Uh oh!

dreamofabear commented Sep 30, 2019

Uh oh!

dreamofabear left a comment

Choose a reason for hiding this comment

Uh oh!

cramforce commented Sep 30, 2019

Uh oh!

alabiaga commented Oct 1, 2019

Uh oh!

msoo14131 Aug 4, 2024

Choose a reason for hiding this comment

Uh oh!

msoo14131 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants