Skip to content

🔥 Revert "Remove launched experiments. (#16528)"#16678

Merged
cvializ merged 1 commit intoampproject:masterfrom
jridgewell:revert-remove-experiments
Jul 11, 2018
Merged

🔥 Revert "Remove launched experiments. (#16528)"#16678
cvializ merged 1 commit intoampproject:masterfrom
jridgewell:revert-remove-experiments

Conversation

@jridgewell
Copy link
Copy Markdown
Contributor

@jridgewell jridgewell commented Jul 11, 2018

This reverts commit 3a3dbd9.
(PR: #16528)

This will need a more thorough review in light of #16671.

Fixes #16671.
Fixes #16674.

@jridgewell jridgewell requested a review from cvializ July 11, 2018 15:36
@jridgewell jridgewell changed the title Revert "Remove launched experiments. (#16528)" 🔥 Revert "Remove launched experiments. (#16528)" Jul 11, 2018
@cvializ cvializ merged commit 366b9d5 into ampproject:master Jul 11, 2018
Copy link
Copy Markdown
Contributor

@cvializ cvializ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jridgewell jridgewell deleted the revert-remove-experiments branch July 11, 2018 16:04
cvializ pushed a commit that referenced this pull request Jul 11, 2018
erwinmombay pushed a commit that referenced this pull request Jul 11, 2018
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 4, 2020
Config last modified up to 2019-12-06T08:00:09.679Z:

- (ampproject#17012) `amp-access-iframe` (on)
- (ampproject#24810) `amp-action-macro` (on)
- (ampproject#25480) `amp-mega-menu` (on)
- (ampproject#25516) `amp-nested-menu` (on)
- (ampproject#7403) `amp-playbuzz` (on)
- (ampproject#25170) `amp-sidebar-swipe-to-dismiss` (on)
- (ampproject#19140) `amp-story-responsive-units` (on)
- (ampproject#16678) `amp-story-v1` (on)
- (ampproject#16678) `chunked-amp` (on)
- (ampproject#25269) `fix-inconsistent-responsive-height-selection` (off)
- (ampproject#21058) `fixed-elements-in-lightbox` (on)
- (ampproject#9298) `pump-early-frame` (on)
- (ampproject#25512) `swg-gpay-native` (on)⚠️ **This changes Javascript source files**

The following may contain errors, and require intervention to remove superfluous conditionals:

- `extensions/amp-access/0.1/amp-access-source.js`
- `extensions/amp-access/0.1/test/test-amp-access-source.js`
- `extensions/amp-action-macro/0.1/amp-action-macro.js`
- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`
- `extensions/amp-playbuzz/0.1/amp-playbuzz.js`
- `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js`
- `extensions/amp-sidebar/0.1/amp-sidebar.js`
- `extensions/amp-sidebar/0.2/amp-sidebar.js`
- `extensions/amp-story/1.0/amp-story.js`
- `extensions/amp-story/1.0/test/test-amp-story.js`
- `src/runtime.js`
- `test/unit/test-runtime.js`
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 4, 2020
Sweep experiments last flipped globally up to 2019-12-06T08:00:02.356Z:

- (ampproject#17012) `amp-access-iframe` (on)
- (ampproject#24810) `amp-action-macro` (on)
- (ampproject#25480) `amp-mega-menu` (on)
- (ampproject#25516) `amp-nested-menu` (on)
- (ampproject#7403) `amp-playbuzz` (on)
- (ampproject#25170) `amp-sidebar-swipe-to-dismiss` (on)
- (ampproject#19140) `amp-story-responsive-units` (on)
- (ampproject#16678) `amp-story-v1` (on)
- (ampproject#16678) `chunked-amp` (on)
- (ampproject#25269) `fix-inconsistent-responsive-height-selection` (off)
- (ampproject#21058) `fixed-elements-in-lightbox` (on)
- (ampproject#9298) `pump-early-frame` (on)
- (ampproject#25512) `swg-gpay-native` (on)

---

**⚠️ This changes Javascript source files**

The following may contain errors, and require intervention to remove superfluous conditionals:

- `extensions/amp-access/0.1/amp-access-source.js`
- `extensions/amp-access/0.1/test/test-amp-access-source.js`
- `extensions/amp-action-macro/0.1/amp-action-macro.js`
- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`
- `extensions/amp-playbuzz/0.1/amp-playbuzz.js`
- `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js`
- `extensions/amp-sidebar/0.1/amp-sidebar.js`
- `extensions/amp-sidebar/0.2/amp-sidebar.js`
- `extensions/amp-story/1.0/amp-story.js`
- `extensions/amp-story/1.0/test/test-amp-story.js`
- `src/runtime.js`
- `test/unit/test-runtime.js`
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert $1Remove launched experiments. (ampproject#16528)$1 (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 1194c16 - 2018-06-12T11:38:38-04:00
   Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert $1Remove launched experiments. (ampproject#16528)$1 (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 34ffcdb - 2017-02-17T13:10:59-08:00
   turn on chunked-amp (ampproject#7645)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-06T08:00:26.122Z:

- (ampproject#17012) `amp-access-iframe` (on)
- (ampproject#24810) `amp-action-macro` (on)
- (ampproject#25480) `amp-mega-menu` (on)
- (ampproject#25516) `amp-nested-menu` (on)
- (ampproject#7403) `amp-playbuzz` (on)
- (ampproject#25170) `amp-sidebar-swipe-to-dismiss` (on)
- (ampproject#19140) `amp-story-responsive-units` (on)
- (ampproject#16678) `amp-story-v1` (on)
- (ampproject#16678) `chunked-amp` (on)
- (ampproject#25269) `fix-inconsistent-responsive-height-selection` (off)
- (ampproject#21058) `fixed-elements-in-lightbox` (on)
- (ampproject#9298) `pump-early-frame` (on)
- (ampproject#25512) `swg-gpay-native` (on)

---

**⚠️ This changes Javascript source files**

The following may contain errors, and require intervention to remove superfluous conditionals:

- `extensions/amp-access/0.1/amp-access-source.js`
- `extensions/amp-access/0.1/test/test-amp-access-source.js`
- `extensions/amp-action-macro/0.1/amp-action-macro.js`
- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`
- `extensions/amp-playbuzz/0.1/amp-playbuzz.js`
- `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js`
- `extensions/amp-sidebar/0.1/amp-sidebar.js`
- `extensions/amp-sidebar/0.2/amp-sidebar.js`
- `extensions/amp-story/1.0/amp-story.js`
- `extensions/amp-story/1.0/test/test-amp-story.js`
- `src/runtime.js`
- `test/unit/test-runtime.js`
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 1194c16 - 2018-06-12T11:38:38-04:00
   Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 34ffcdb - 2017-02-17T13:10:59-08:00
   turn on chunked-amp (ampproject#7645)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-06:

- (2019-10-01, ampproject#24810) amp-action-macro: 1
- (2018-11-05, ampproject#19140) amp-story-responsive-units: 1
- (2018-07-11, ampproject#16678) amp-story-v1: 1
- (2018-07-11, ampproject#16678) chunked-amp: 1
- (2019-10-28, ampproject#25269) fix-inconsistent-responsive-height-selection: 0
- (2017-05-16, ampproject#9298) pump-early-frame: 1
- (2019-11-12, ampproject#25512) swg-gpay-native: 1

---

**⚠️ This changes Javascript source files**

The following may contain errors and/or require intervention to remove superfluous conditionals:

- `extensions/amp-action-macro/0.1/amp-action-macro.js`
- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`
- `extensions/amp-story/1.0/amp-story.js`
- `extensions/amp-story/1.0/test/test-amp-story.js`
- `src/runtime.js`
- `test/unit/test-runtime.js`
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 1194c16 - 2018-06-12T11:38:38-04:00
   Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 34ffcdb - 2017-02-17T13:10:59-08:00
   turn on chunked-amp (ampproject#7645)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-06:

- (2018-07-23, ampproject#17012) amp-access-iframe: 1
- (2019-10-01, ampproject#24810) amp-action-macro: 1
- (2019-11-08, ampproject#25480) amp-mega-menu: 1
- (2019-11-13, ampproject#25516) amp-nested-menu: 1
- (2017-02-07, ampproject#7403) amp-playbuzz: 1
- (2019-10-21, ampproject#25170) amp-sidebar-swipe-to-dismiss: 1
- (2018-11-05, ampproject#19140) amp-story-responsive-units: 1
- (2018-07-11, ampproject#16678) amp-story-v1: 1
- (2018-07-11, ampproject#16678) chunked-amp: 1
- (2019-10-28, ampproject#25269) fix-inconsistent-responsive-height-selection: 0
- (2019-02-26, ampproject#21058) fixed-elements-in-lightbox: 1
- (2017-05-16, ampproject#9298) pump-early-frame: 1
- (2019-11-12, ampproject#25512) swg-gpay-native: 1

---

**⚠️ This changes Javascript source files**

The following may contain errors and/or require intervention to remove superfluous conditionals:

- `extensions/amp-access/0.1/amp-access-source.js`
- `extensions/amp-access/0.1/test/test-amp-access-source.js`
- `extensions/amp-action-macro/0.1/amp-action-macro.js`
- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`
- `extensions/amp-playbuzz/0.1/amp-playbuzz.js`
- `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js`
- `extensions/amp-sidebar/0.1/amp-sidebar.js`
- `extensions/amp-sidebar/0.2/amp-sidebar.js`
- `extensions/amp-story/1.0/amp-story.js`
- `extensions/amp-story/1.0/test/test-amp-story.js`
- `src/runtime.js`
- `test/unit/test-runtime.js`
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 1194c16 - 2018-06-12T11:38:38-04:00
   Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 34ffcdb - 2017-02-17T13:10:59-08:00
   turn on chunked-amp (ampproject#7645)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-06:

- (2018-07-23, ampproject#17012) `amp-access-iframe`: 1
- (2019-10-01, ampproject#24810) `amp-action-macro`: 1
- (2019-11-08, ampproject#25480) `amp-mega-menu`: 1
- (2019-11-13, ampproject#25516) `amp-nested-menu`: 1
- (2017-02-07, ampproject#7403) `amp-playbuzz`: 1
- (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1
- (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1
- (2018-07-11, ampproject#16678) `amp-story-v1`: 1
- (2018-07-11, ampproject#16678) `chunked-amp`: 1
- (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0
- (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1
- (2017-05-16, ampproject#9298) `pump-early-frame`: 1
- (2019-11-12, ampproject#25512) `swg-gpay-native`: 1

---

**⚠️ This changes Javascript source files**

The following may contain errors and/or require intervention to remove superfluous conditionals:

- `extensions/amp-access/0.1/amp-access-source.js`
- `extensions/amp-access/0.1/test/test-amp-access-source.js`
- `extensions/amp-action-macro/0.1/amp-action-macro.js`
- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`
- `extensions/amp-playbuzz/0.1/amp-playbuzz.js`
- `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js`
- `extensions/amp-sidebar/0.1/amp-sidebar.js`
- `extensions/amp-sidebar/0.2/amp-sidebar.js`
- `extensions/amp-story/1.0/amp-story.js`
- `extensions/amp-story/1.0/test/test-amp-story.js`
- `src/runtime.js`
- `test/unit/test-runtime.js`
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 1194c16 - 2018-06-12T11:38:38-04:00
   Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 34ffcdb - 2017-02-17T13:10:59-08:00
   turn on chunked-amp (ampproject#7645)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 34ffcdb - 2017-02-17T13:10:59-08:00
   turn on chunked-amp (ampproject#7645)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-04:

- (2018-07-23, ampproject#17012) `amp-access-iframe`: 1
- (2019-10-01, ampproject#24810) `amp-action-macro`: 1
- (2019-11-08, ampproject#25480) `amp-mega-menu`: 1
- (2019-11-13, ampproject#25516) `amp-nested-menu`: 1
- (2017-02-07, ampproject#7403) `amp-playbuzz`: 1
- (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1
- (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1
- (2018-07-11, ampproject#16678) `amp-story-v1`: 1
- (2018-07-11, ampproject#16678) `chunked-amp`: 1
- (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0
- (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1
- (2017-05-16, ampproject#9298) `pump-early-frame`: 1
- (2019-11-12, ampproject#25512) `swg-gpay-native`: 1

---

**⚠️ This changes Javascript source files**

The following may contain errors and/or require intervention to remove superfluous conditionals:

- `extensions/amp-access/0.1/amp-access-source.js`
- `extensions/amp-access/0.1/test/test-amp-access-source.js`
- `extensions/amp-action-macro/0.1/amp-action-macro.js`
- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`
- `extensions/amp-playbuzz/0.1/amp-playbuzz.js`
- `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js`
- `extensions/amp-sidebar/0.1/amp-sidebar.js`
- `extensions/amp-sidebar/0.2/amp-sidebar.js`
- `extensions/amp-story/1.0/amp-story.js`
- `extensions/amp-story/1.0/test/test-amp-story.js`
- `src/runtime.js`
- `test/unit/test-runtime.js`
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 1194c16 - 2018-06-12T11:38:38-04:00
   Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 34ffcdb - 2017-02-17T13:10:59-08:00
   turn on chunked-amp (ampproject#7645)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-04:

- (2018-07-23, ampproject#17012) `amp-access-iframe`: 1
- (2019-10-01, ampproject#24810) `amp-action-macro`: 1
- (2019-11-08, ampproject#25480) `amp-mega-menu`: 1
- (2019-11-13, ampproject#25516) `amp-nested-menu`: 1
- (2017-02-07, ampproject#7403) `amp-playbuzz`: 1
- (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1
- (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1
- (2018-07-11, ampproject#16678) `amp-story-v1`: 1
- (2018-07-11, ampproject#16678) `chunked-amp`: 1
- (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0
- (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1
- (2017-05-16, ampproject#9298) `pump-early-frame`: 1
- (2019-11-12, ampproject#25512) `swg-gpay-native`: 1

---

**⚠️ This changes Javascript source files**

The following may contain errors and/or require intervention to remove superfluous conditionals:

- `extensions/amp-access/0.1/amp-access-source.js`
- `extensions/amp-access/0.1/test/test-amp-access-source.js`
- `extensions/amp-action-macro/0.1/amp-action-macro.js`
- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`
- `extensions/amp-playbuzz/0.1/amp-playbuzz.js`
- `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js`
- `extensions/amp-sidebar/0.1/amp-sidebar.js`
- `extensions/amp-sidebar/0.2/amp-sidebar.js`
- `extensions/amp-story/1.0/amp-story.js`
- `extensions/amp-story/1.0/test/test-amp-story.js`
- `src/runtime.js`
- `test/unit/test-runtime.js`
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 1194c16 - 2018-06-12T11:38:38-04:00
   Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 34ffcdb - 2017-02-17T13:10:59-08:00
   turn on chunked-amp (ampproject#7645)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-04:

- (2018-07-23, ampproject#17012) `amp-access-iframe`: 1
- (2019-10-01, ampproject#24810) `amp-action-macro`: 1
- (2019-11-08, ampproject#25480) `amp-mega-menu`: 1
- (2019-11-13, ampproject#25516) `amp-nested-menu`: 1
- (2017-02-07, ampproject#7403) `amp-playbuzz`: 1
- (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1
- (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1
- (2018-07-11, ampproject#16678) `amp-story-v1`: 1
- (2018-07-11, ampproject#16678) `chunked-amp`: 1
- (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0
- (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1
- (2017-05-16, ampproject#9298) `pump-early-frame`: 1
- (2019-11-12, ampproject#25512) `swg-gpay-native`: 1

---

**⚠️ This changes Javascript source files**

The following may contain errors and/or require intervention to remove superfluous conditionals:

- `extensions/amp-access/0.1/amp-access-source.js`
- `extensions/amp-access/0.1/test/test-amp-access-source.js`
- `extensions/amp-action-macro/0.1/amp-action-macro.js`
- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`
- `extensions/amp-playbuzz/0.1/amp-playbuzz.js`
- `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js`
- `extensions/amp-sidebar/0.1/amp-sidebar.js`
- `extensions/amp-sidebar/0.2/amp-sidebar.js`
- `extensions/amp-story/1.0/amp-story.js`
- `extensions/amp-story/1.0/test/test-amp-story.js`
- `src/runtime.js`
- `test/unit/test-runtime.js`
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 1194c16 - 2018-06-12T11:38:38-04:00
   Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 34ffcdb - 2017-02-17T13:10:59-08:00
   turn on chunked-amp (ampproject#7645)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-05:

- (2018-07-23, ampproject#17012) `amp-access-iframe`: 1
- (2019-10-01, ampproject#24810) `amp-action-macro`: 1
- (2019-11-08, ampproject#25480) `amp-mega-menu`: 1
- (2019-11-13, ampproject#25516) `amp-nested-menu`: 1
- (2017-02-07, ampproject#7403) `amp-playbuzz`: 1
- (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1
- (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1
- (2018-07-11, ampproject#16678) `amp-story-v1`: 1
- (2018-07-11, ampproject#16678) `chunked-amp`: 1
- (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0
- (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1
- (2017-05-16, ampproject#9298) `pump-early-frame`: 1
- (2019-11-12, ampproject#25512) `swg-gpay-native`: 1

---

**⚠️ This changes Javascript source files**

The following may contain errors and/or require intervention to remove superfluous conditionals:

- `extensions/amp-access/0.1/amp-access-source.js`
- `extensions/amp-access/0.1/test/test-amp-access-source.js`
- `extensions/amp-action-macro/0.1/amp-action-macro.js`
- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`
- `extensions/amp-playbuzz/0.1/amp-playbuzz.js`
- `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js`
- `extensions/amp-sidebar/0.1/amp-sidebar.js`
- `extensions/amp-sidebar/0.2/amp-sidebar.js`
- `extensions/amp-story/1.0/amp-story.js`
- `extensions/amp-story/1.0/test/test-amp-story.js`
- `src/runtime.js`
- `test/unit/test-runtime.js`

---

**⚠️ There are HTML files with possible references**

The following HTML files contain references to experiment names which may be stale and should be manually removed:

- `examples/playbuzz.amp.html`
- `examples/responsive-menu.amp.html`
- `examples/visual-tests/amp-mega-menu/amp-mega-menu.amp.html`
- `examples/visual-tests/amp-mega-menu/amp-mega-menu-with-list.amp.html`
- `examples/amp-action-macro.html`
- `test/manual/amp-mega-menu/amp-mega-menu.amp.html`
- `test/manual/amp-mega-menu/amp-mega-menu-with-list.amp.html`
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
…history:\n\n - 366b9d5 - 2018-07-11T12:03:09-04:00\n   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)\n\n - 3a3dbd9 - 2018-07-06T14:47:49-04:00\n   Remove launched experiments. (ampproject#16528)\n\n - 1194c16 - 2018-06-12T11:38:38-04:00\n   Start canonical adsense fast fetch experiments at 1% (ampproject#15979)\n
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
…istory:\n\n - 366b9d5 - 2018-07-11T12:03:09-04:00\n   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)\n\n - 3a3dbd9 - 2018-07-06T14:47:49-04:00\n   Remove launched experiments. (ampproject#16528)\n\n - 34ffcdb - 2017-02-17T13:10:59-08:00\n   turn on chunked-amp (ampproject#7645)\n
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
…lipped globally up to 2019-12-05:\n\n- (2018-07-23, ampproject#17012) `amp-access-iframe`: 1\n- (2019-10-01, ampproject#24810) `amp-action-macro`: 1\n- (2019-11-08, ampproject#25480) `amp-mega-menu`: 1\n- (2019-11-13, ampproject#25516) `amp-nested-menu`: 1\n- (2017-02-07, ampproject#7403) `amp-playbuzz`: 1\n- (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1\n- (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1\n- (2018-07-11, ampproject#16678) `amp-story-v1`: 1\n- (2018-07-11, ampproject#16678) `chunked-amp`: 1\n- (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0\n- (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1\n- (2017-05-16, ampproject#9298) `pump-early-frame`: 1\n- (2019-11-12, ampproject#25512) `swg-gpay-native`: 1\n\n---\n\n**⚠️ This changes Javascript source files**\n\nThe following may contain errors and/or require intervention to remove superfluous conditionals:\n\n- `extensions/amp-access/0.1/amp-access-source.js`\n- `extensions/amp-access/0.1/test/test-amp-access-source.js`\n- `extensions/amp-action-macro/0.1/amp-action-macro.js`\n- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`\n- `extensions/amp-playbuzz/0.1/amp-playbuzz.js`\n- `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js`\n- `extensions/amp-sidebar/0.1/amp-sidebar.js`\n- `extensions/amp-sidebar/0.2/amp-sidebar.js`\n- `extensions/amp-story/1.0/amp-story.js`\n- `extensions/amp-story/1.0/test/test-amp-story.js`\n- `src/runtime.js`\n- `test/unit/test-runtime.js`\n\n---\n\n**⚠️ There are HTML files with possible references**\n\nThe following HTML files contain references to experiment names which may be stale and should be manually removed:\n\n- `examples/playbuzz.amp.html`\n- `examples/responsive-menu.amp.html`\n- `examples/amp-action-macro.html`\n- `examples/visual-tests/amp-mega-menu/amp-mega-menu-with-list.amp.html`\n- `examples/visual-tests/amp-mega-menu/amp-mega-menu.amp.html`\n- `test/manual/amp-mega-menu/amp-mega-menu-with-list.amp.html`\n- `test/manual/amp-mega-menu/amp-mega-menu.amp.html`\n\n
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 1194c16 - 2018-06-12T11:38:38-04:00
   Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 34ffcdb - 2017-02-17T13:10:59-08:00
   turn on chunked-amp (ampproject#7645)
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-05:

- (2018-07-23, ampproject#17012) `amp-access-iframe`: 1
- (2019-10-01, ampproject#24810) `amp-action-macro`: 1
- (2019-11-08, ampproject#25480) `amp-mega-menu`: 1
- (2019-11-13, ampproject#25516) `amp-nested-menu`: 1
- (2017-02-07, ampproject#7403) `amp-playbuzz`: 1
- (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1
- (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1
- (2018-07-11, ampproject#16678) `amp-story-v1`: 1
- (2018-07-11, ampproject#16678) `chunked-amp`: 1
- (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0
- (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1
- (2017-05-16, ampproject#9298) `pump-early-frame`: 1
- (2019-11-12, ampproject#25512) `swg-gpay-native`: 1

---

**⚠️ This changes Javascript source files**

The following may contain errors and/or require intervention to remove superfluous conditionals:

- `extensions/amp-access/0.1/amp-access-source.js`
- `extensions/amp-access/0.1/test/test-amp-access-source.js`
- `extensions/amp-action-macro/0.1/amp-action-macro.js`
- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`
- `extensions/amp-playbuzz/0.1/amp-playbuzz.js`
- `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js`
- `extensions/amp-sidebar/0.1/amp-sidebar.js`
- `extensions/amp-sidebar/0.2/amp-sidebar.js`
- `extensions/amp-story/1.0/amp-story.js`
- `extensions/amp-story/1.0/test/test-amp-story.js`
- `src/runtime.js`
- `test/unit/test-runtime.js`

---

**⚠️ There are HTML files with possible references**

The following HTML files contain references to experiment names which may be stale and should be manually removed:

- `examples/playbuzz.amp.html`
- `examples/responsive-menu.amp.html`
- `examples/amp-action-macro.html`
- `examples/visual-tests/amp-mega-menu/amp-mega-menu-with-list.amp.html`
- `examples/visual-tests/amp-mega-menu/amp-mega-menu.amp.html`
- `test/manual/amp-mega-menu/amp-mega-menu-with-list.amp.html`
- `test/manual/amp-mega-menu/amp-mega-menu.amp.html`
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 1194c16 - 2018-06-12T11:38:38-04:00
   Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
prod-config.json history:

 - 366b9d5 - 2018-07-11T12:03:09-04:00
   Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)

 - 3a3dbd9 - 2018-07-06T14:47:49-04:00
   Remove launched experiments. (ampproject#16528)

 - 34ffcdb - 2017-02-17T13:10:59-08:00
   turn on chunked-amp (ampproject#7645)
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
Sweep experiments last flipped globally up to 2019-12-05:

- (2018-07-23, ampproject#17012) `amp-access-iframe`: 1
- (2019-10-01, ampproject#24810) `amp-action-macro`: 1
- (2019-11-08, ampproject#25480) `amp-mega-menu`: 1
- (2019-11-13, ampproject#25516) `amp-nested-menu`: 1
- (2017-02-07, ampproject#7403) `amp-playbuzz`: 1
- (2019-10-21, ampproject#25170) `amp-sidebar-swipe-to-dismiss`: 1
- (2018-11-05, ampproject#19140) `amp-story-responsive-units`: 1
- (2018-07-11, ampproject#16678) `amp-story-v1`: 1
- (2018-07-11, ampproject#16678) `chunked-amp`: 1
- (2019-10-28, ampproject#25269) `fix-inconsistent-responsive-height-selection`: 0
- (2019-02-26, ampproject#21058) `fixed-elements-in-lightbox`: 1
- (2017-05-16, ampproject#9298) `pump-early-frame`: 1
- (2019-11-12, ampproject#25512) `swg-gpay-native`: 1

---

**⚠️ This changes Javascript source files**

The following may contain errors and/or require intervention to remove superfluous conditionals:

- `extensions/amp-access/0.1/amp-access-source.js`
- `extensions/amp-access/0.1/test/test-amp-access-source.js`
- `extensions/amp-action-macro/0.1/amp-action-macro.js`
- `extensions/amp-action-macro/0.1/test/test-amp-action-macro.js`
- `extensions/amp-playbuzz/0.1/amp-playbuzz.js`
- `extensions/amp-playbuzz/0.1/test/test-amp-playbuzz.js`
- `extensions/amp-sidebar/0.1/amp-sidebar.js`
- `extensions/amp-sidebar/0.2/amp-sidebar.js`
- `extensions/amp-story/1.0/amp-story.js`
- `extensions/amp-story/1.0/test/test-amp-story.js`
- `src/runtime.js`
- `test/unit/test-runtime.js`

---

**⚠️ There are HTML files with possible references**

The following HTML files contain references to experiment names which may be stale and should be manually removed:

- `examples/playbuzz.amp.html`
- `examples/responsive-menu.amp.html`
- `examples/amp-action-macro.html`
- `examples/visual-tests/amp-mega-menu/amp-mega-menu-with-list.amp.html`
- `examples/visual-tests/amp-mega-menu/amp-mega-menu.amp.html`
- `test/manual/amp-mega-menu/amp-mega-menu-with-list.amp.html`
- `test/manual/amp-mega-menu/amp-mega-menu.amp.html`
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 6, 2020
Previous history on prod-config.json:

- 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert,"Remove,launched,experiments.,(ampproject#16528)",(ampproject#16678)

- 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove,launched,experiments.,(ampproject#16528)

- 1194c16 - 2018-06-12T11:38:38-04:00 - Start,canonical,adsense,fast,fetch,experiments,at,1%,(ampproject#15979)
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 6, 2020
Previous history on prod-config.json:

- 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert,"Remove,launched,experiments.,(ampproject#16528)",(ampproject#16678)

- 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove,launched,experiments.,(ampproject#16528)

- 34ffcdb - 2017-02-17T13:10:59-08:00 - turn,on,chunked-amp,(ampproject#7645)
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 6, 2020
Previous history on prod-config.json:

- 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert,"Remove,launched,experiments.,(ampproject#16528)",(ampproject#16678)

- 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove,launched,experiments.,(ampproject#16528)

- 1194c16 - 2018-06-12T11:38:38-04:00 - Start,canonical,adsense,fast,fetch,experiments,at,1%,(ampproject#15979)
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 6, 2020
Previous history on prod-config.json:

- 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert,"Remove,launched,experiments.,(ampproject#16528)",(ampproject#16678)

- 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove,launched,experiments.,(ampproject#16528)

- 34ffcdb - 2017-02-17T13:10:59-08:00 - turn,on,chunked-amp,(ampproject#7645)
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 7, 2020
Previous history on prod-config.json:

- 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert,"Remove,launched,experiments.,(ampproject#16528)",(ampproject#16678)

- 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove,launched,experiments.,(ampproject#16528)

- 1194c16 - 2018-06-12T11:38:38-04:00 - Start,canonical,adsense,fast,fetch,experiments,at,1%,(ampproject#15979)
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 7, 2020
Previous history on prod-config.json:

- 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert,"Remove,launched,experiments.,(ampproject#16528)",(ampproject#16678)

- 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove,launched,experiments.,(ampproject#16528)

- 34ffcdb - 2017-02-17T13:10:59-08:00 - turn,on,chunked-amp,(ampproject#7645)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 7, 2020
Previous history on prod-config.json:

- 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)
- 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. (ampproject#16528)
- 1194c16 - 2018-06-12T11:38:38-04:00 - Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 7, 2020
Previous history on prod-config.json:

- 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678)
- 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. (ampproject#16528)
- 34ffcdb - 2017-02-17T13:10:59-08:00 - turn on chunked-amp (ampproject#7645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants