Remove launched experiments#16528
Merged
dreamofabear merged 2 commits intoampproject:masterfrom Jul 6, 2018
Merged
Conversation
lannka
approved these changes
Jul 3, 2018
aghassemi
approved these changes
Jul 6, 2018
Contributor
aghassemi
left a comment
There was a problem hiding this comment.
lGTM for apster, I'ma, animation and sidebar
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Jul 11, 2018
This reverts commit 3a3dbd9.
cvializ
pushed a commit
that referenced
this pull request
Jul 11, 2018
cvializ
pushed a commit
that referenced
this pull request
Jul 11, 2018
erwinmombay
pushed a commit
that referenced
this pull request
Jul 11, 2018
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Jul 11, 2018
The root cause of ampproject#16671 (from ampproject#16528) is difficutly grepping for used experiment flags. So, make them very grepable. ```js // BAD const EXP = 'experiment-name'; isExperimentOn(win, EXP); // GOOD isExperimentOn(win, 'experiment-name');
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Jul 12, 2018
The root cause of ampproject#16671 (from ampproject#16528) is difficutly grepping for used experiment flags. So, make them very grepable. ```js // BAD const EXP = 'experiment-name'; isExperimentOn(win, EXP); // GOOD isExperimentOn(win, 'experiment-name');
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 366b9d5 - 2018-07-11T12:03:09-04:00 Revert $1Remove launched experiments. (ampproject#16528)$1 (ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 Remove launched experiments. (ampproject#16528) - 1194c16 - 2018-06-12T11:38:38-04:00 Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 366b9d5 - 2018-07-11T12:03:09-04:00 Revert $1Remove launched experiments. (ampproject#16528)$1 (ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 Remove launched experiments. (ampproject#16528) - 34ffcdb - 2017-02-17T13:10:59-08:00 turn on chunked-amp (ampproject#7645)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 366b9d5 - 2018-07-11T12:03:09-04:00 Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 Remove launched experiments. (ampproject#16528) - 1194c16 - 2018-06-12T11:38:38-04:00 Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 366b9d5 - 2018-07-11T12:03:09-04:00 Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 Remove launched experiments. (ampproject#16528) - 34ffcdb - 2017-02-17T13:10:59-08:00 turn on chunked-amp (ampproject#7645)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 366b9d5 - 2018-07-11T12:03:09-04:00 Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 Remove launched experiments. (ampproject#16528) - 1194c16 - 2018-06-12T11:38:38-04:00 Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 366b9d5 - 2018-07-11T12:03:09-04:00 Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 Remove launched experiments. (ampproject#16528) - 34ffcdb - 2017-02-17T13:10:59-08:00 turn on chunked-amp (ampproject#7645)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 366b9d5 - 2018-07-11T12:03:09-04:00 Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 Remove launched experiments. (ampproject#16528) - 1194c16 - 2018-06-12T11:38:38-04:00 Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 366b9d5 - 2018-07-11T12:03:09-04:00 Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 Remove launched experiments. (ampproject#16528) - 34ffcdb - 2017-02-17T13:10:59-08:00 turn on chunked-amp (ampproject#7645)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 366b9d5 - 2018-07-11T12:03:09-04:00 Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 Remove launched experiments. (ampproject#16528) - 1194c16 - 2018-06-12T11:38:38-04:00 Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 366b9d5 - 2018-07-11T12:03:09-04:00 Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 Remove launched experiments. (ampproject#16528) - 1194c16 - 2018-06-12T11:38:38-04:00 Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - 366b9d5 - 2018-07-11T12:03:09-04:00 Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 Remove launched experiments. (ampproject#16528) - 34ffcdb - 2017-02-17T13:10:59-08:00 turn on chunked-amp (ampproject#7645)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 6, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert,"Remove,launched,experiments.,(ampproject#16528)",(ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove,launched,experiments.,(ampproject#16528) - 1194c16 - 2018-06-12T11:38:38-04:00 - Start,canonical,adsense,fast,fetch,experiments,at,1%,(ampproject#15979)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 6, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert,"Remove,launched,experiments.,(ampproject#16528)",(ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove,launched,experiments.,(ampproject#16528) - 34ffcdb - 2017-02-17T13:10:59-08:00 - turn,on,chunked-amp,(ampproject#7645)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 6, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert,"Remove,launched,experiments.,(ampproject#16528)",(ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove,launched,experiments.,(ampproject#16528) - 1194c16 - 2018-06-12T11:38:38-04:00 - Start,canonical,adsense,fast,fetch,experiments,at,1%,(ampproject#15979)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 6, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert,"Remove,launched,experiments.,(ampproject#16528)",(ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove,launched,experiments.,(ampproject#16528) - 34ffcdb - 2017-02-17T13:10:59-08:00 - turn,on,chunked-amp,(ampproject#7645)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert,"Remove,launched,experiments.,(ampproject#16528)",(ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove,launched,experiments.,(ampproject#16528) - 1194c16 - 2018-06-12T11:38:38-04:00 - Start,canonical,adsense,fast,fetch,experiments,at,1%,(ampproject#15979)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert,"Remove,launched,experiments.,(ampproject#16528)",(ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove,launched,experiments.,(ampproject#16528) - 34ffcdb - 2017-02-17T13:10:59-08:00 - turn,on,chunked-amp,(ampproject#7645)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. (ampproject#16528) - 1194c16 - 2018-06-12T11:38:38-04:00 - Start canonical adsense fast fetch experiments at 1% (ampproject#15979)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" (ampproject#16678) - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. (ampproject#16528) - 34ffcdb - 2017-02-17T13:10:59-08:00 - turn on chunked-amp (ampproject#7645)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 1194c16 - 2018-06-12T11:38:38-04:00 - Start canonical adsense fast fetch experiments at 1%
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 34ffcdb - 2017-02-17T13:10:59-08:00 - turn on chunked-amp
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 1194c16 - 2018-06-12T11:38:38-04:00 - Start canonical adsense fast fetch experiments at 1%
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 34ffcdb - 2017-02-17T13:10:59-08:00 - turn on chunked-amp
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 1194c16 - 2018-06-12T11:38:38-04:00 - Start canonical adsense fast fetch experiments at 1%
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 34ffcdb - 2017-02-17T13:10:59-08:00 - turn on chunked-amp
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 1194c16 - 2018-06-12T11:38:38-04:00 - Start canonical adsense fast fetch experiments at 1%
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 34ffcdb - 2017-02-17T13:10:59-08:00 - turn on chunked-amp
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 1194c16 - 2018-06-12T11:38:38-04:00 - Start canonical adsense fast fetch experiments at 1%
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 34ffcdb - 2017-02-17T13:10:59-08:00 - turn on chunked-amp
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 1194c16 - 2018-06-12T11:38:38-04:00 - Start canonical adsense fast fetch experiments at 1%
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 34ffcdb - 2017-02-17T13:10:59-08:00 - turn on chunked-amp
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 1194c16 - 2018-06-12T11:38:38-04:00 - Start canonical adsense fast fetch experiments at 1%
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 34ffcdb - 2017-02-17T13:10:59-08:00 - turn on chunked-amp
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 1194c16 - 2018-06-12T11:38:38-04:00 - Start canonical adsense fast fetch experiments at 1%
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 34ffcdb - 2017-02-17T13:10:59-08:00 - turn on chunked-amp
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 1194c16 - 2018-06-12T11:38:38-04:00 - Start canonical adsense fast fetch experiments at 1%
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 34ffcdb - 2017-02-17T13:10:59-08:00 - turn on chunked-amp
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 8, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 1194c16 - 2018-06-12T11:38:38-04:00 - Start canonical adsense fast fetch experiments at 1%
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 8, 2020
Previous history on prod-config.json: - 366b9d5 - 2018-07-11T12:03:09-04:00 - Revert "Remove launched experiments. (ampproject#16528)" - 3a3dbd9 - 2018-07-06T14:47:49-04:00 - Remove launched experiments. - 34ffcdb - 2017-02-17T13:10:59-08:00 - turn on chunked-amp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing experiments that have been launched for ~30+ days and have no runtime checks i.e.
isExperimentOn()./to @lannka @aghassemi @newmuis