🚮 Launched experiment sweep#31438
Merged
alanorozco merged 8 commits intoampproject:masterfrom Dec 8, 2020
Merged
Conversation
dvoytenko
approved these changes
Dec 4, 2020
jridgewell
approved these changes
Dec 4, 2020
zhouyx
approved these changes
Dec 4, 2020
Member
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
- (ampproject#17012) `amp-access-iframe` (cleanup issue ampproject#13287) - (ampproject#25480) `amp-mega-menu` - (ampproject#25516) `amp-nested-menu` - (ampproject#6947) `amp-playbuzz` (cleanup issue ampproject#6351) - (ampproject#25170) `amp-sidebar-swipe-to-dismiss` - (ampproject#21058) `fixed-elements-in-lightbox` - (ampproject#25512) `swg-gpay-native` - (ampproject#26021) `swg-gpay-api`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launched at 100% over 12 months ago, these experiments bits are polluting our release binaries:
amp-access-iframe(cleanup issue Intent to implement: AMP Access client-side via iframe #13287)amp-mega-menuamp-nested-menuamp-playbuzz(cleanup issue Implementing amp-playbuzz extension (#6106) #6351)amp-sidebar-swipe-to-dismissfixed-elements-in-lightboxswg-gpay-nativeswg-gpay-api🤷♂️ Additionally, these have been launched for over a year, but I didn't feel confident enough removing them. Pinging appropriate folks:
amp-action-macro— @samouri — @ampproject/wg-performanceamp-story-responsive-units— @newmuis — @ampproject/wg-storiesamp-story-v1— @newmuis — @ampproject/wg-storieschunked-amp— @jridgewell — @ampproject/wg-performancepump-early-frame— @jridgewell — @ampproject/wg-performance🤷♂️ ...and these have been unlaunched (0%) for over a year also. Similarly, I didn't feel confident enough to remove them. Please provide feedback:
fix-inconsistent-responsive-height-selection— @lannka — @ampproject/wg-monetizationios-fixed-no-transfer— @dvoytenko — @ampproject/wg-performance