🏗 Update node major version in package.json to LTS#19159
🏗 Update node major version in package.json to LTS#19159rsimha merged 1 commit intoampproject:masterfrom rsimha:2018-11-06-NodeMinVer
Conversation
cvializ
left a comment
There was a problem hiding this comment.
I think we want to wait on the discussion, since this will break people who haven't upgraded from 8.x.x to 10.x.x (see #19050 (comment))
|
@cvializ SGTM. Thanks for the pointer. |
|
@cvializ @jridgewell Resulting plan from the discussion: We use the latest LTS on Travis, and allow all active LTS version via PTAL. |
|
This also needs to be added to the validator amphtml/validator/webui/package.json Line 6 in b8445ff amphtml/validator/nodejs/package.json Line 13 in b8445ff amphtml/validator/package.json Line 6 in b8445ff |
|
@cvializ Good point. Coming up. |
|
sg, the build will be red until that change is made. #19051 had to undo this same change last time the node version was updated because of build breakage |
|
Fixed with #19264. Thanks for the heads up. |
We have a new LTS version of
node, so we must update the min version inpackage.jsonand.travis.yml.In
.travis.yml, we can simply specify that the version to use islts/*. However, inpackage.json, we must specify the actual LTS major version, since npm doesn't support a wildcard for LTS. See https://docs.npmjs.com/files/package.json#engines.This is the fix discussed in #19050 (comment)
Follow up to #19046 and #19051
Fixes #19050