Skip to content

🏗 Update allowed nodejs versions for validator#19264

Merged
rsimha merged 1 commit intoampproject:masterfrom
rsimha:2018-11-09-NodeVersion
Nov 12, 2018
Merged

🏗 Update allowed nodejs versions for validator#19264
rsimha merged 1 commit intoampproject:masterfrom
rsimha:2018-11-09-NodeVersion

Conversation

@rsimha
Copy link
Copy Markdown
Contributor

@rsimha rsimha commented Nov 12, 2018

Addresses #19159 (comment)

Follow up to #19159

@rsimha rsimha self-assigned this Nov 12, 2018
@rsimha rsimha requested a review from cvializ November 12, 2018 20:49
@rsimha
Copy link
Copy Markdown
Contributor Author

rsimha commented Nov 12, 2018

/to @cvializ

Copy link
Copy Markdown
Contributor

@cvializ cvializ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rsimha rsimha merged commit 733bef6 into ampproject:master Nov 12, 2018
@rsimha rsimha deleted the 2018-11-09-NodeVersion branch November 12, 2018 20:58
Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants