Merged
Conversation
jridgewell
approved these changes
Oct 30, 2018
dreamofabear
pushed a commit
that referenced
this pull request
Oct 31, 2018
* Fix validator package.json node version * Fix the build
alanorozco
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Nov 1, 2018
* Fix validator package.json node version * Fix the build
alanorozco
pushed a commit
that referenced
this pull request
Nov 1, 2018
* Fix validator package.json node version * Fix the build
Contributor
|
This won't work if you have LTS installed, since the major versions don't match. Sent out a new fix with #19159. |
Contributor
Author
|
That makes sense. This PR was mainly to unblock the build, and the discussion issue #19097 will decide how to proceed with LTS support. It's easy to upgrade and downgrade, so keeping |
cvializ
added a commit
that referenced
this pull request
Nov 6, 2018
* Fix validator package.json node version * Fix the build
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* Fix validator package.json node version * Fix the build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the Travis builds for #19050 for now. Is this the change we decided on for now?