🏗 Update package.json node version. Fixes PR builds.#19046
Merged
cvializ merged 1 commit intoampproject:masterfrom Oct 30, 2018
Merged
🏗 Update package.json node version. Fixes PR builds.#19046cvializ merged 1 commit intoampproject:masterfrom
cvializ merged 1 commit intoampproject:masterfrom
Conversation
alanorozco
approved these changes
Oct 30, 2018
kristoferbaxter
approved these changes
Oct 30, 2018
Contributor
Author
|
Should it be |
Contributor
Author
|
Can adjust if needed, merging now to unblock the team since we have a green build |
This was referenced Oct 30, 2018
alanorozco
pushed a commit
that referenced
this pull request
Nov 1, 2018
Contributor
|
I believe this didn't work because of Travis' caching. Sent out a new fix with #19159. |
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Travis PR builds breaking due to Node LTS version moving from 8 to 10
Sample build https://travis-ci.org/ampproject/amphtml/builds/448458060?utm_source=github_status&utm_medium=notification