Merge master to Release#1338
Merged
camelburrito merged 54 commits intoampproject:releasefrom Jan 7, 2016
Merged
Conversation
- Don’t call `getServices` with a second parameter (it’s not expecting it) - Reorder conditionals to make code clearer
point out that localhost urls are also fine
refactor(amp-user-notification): switch to bottom as default location.
…s-5.0.14 Update postcss to version 5.0.14 🚀
Update del to version 2.2.0 🚀
…it-1.6.1 Update gulp-git to version 1.6.1 🚀
…s-promised-5.2.0 Update chai-as-promised to version 5.2.0 🚀
Build READER_ID and include in access URLs
Check iframe sandbox flags such as (allow-same-origin) in a case-insensitive way
…ript variant in boilerplate-new-visibility.html. This simplifies validation.
Cleanup services module
Moving the amp-boilerplate attr into the style tag, even for noscript variant
Move tap configuration to avoid duplicate calls
Pingback implementation
…0.13.19 Update karma to version 0.13.19 🚀
Update iframe placement docs
Login flow and dialog implementation.
Spec change for ampproject#1315. Does not yet change validator.
Collapse empty ads (When possible)
Opacity is specific to the old boilerplate, which isn't so nice since the error messages include a link to this hash. I'd like to leave in the old one as well since we have already recorded errors that link to that.
In preparation of the new boilerplate, rename the hash to 'boilerplate'.
…ra-0.26.4 Update fs-extra to version 0.26.4 🚀
1. The switch from viewport change to the more frequent scroll dropped sending events on resize. 2. Also send changes on remeasure, as our size might have changed for some reason.
Fix 2 edge cases in ad viewability
Tighten the spec file rules with respect to custom Javascript.
Bugfix: Improve the line numbers emmitted by the validator. Remove support for relative amp runtime.
…s for CSS errors.
Validator: Reduce the amount of english language in the error messages for CSS errors.
Do not close lightbox on tap
fix(cid): localhost should only be considered as proxy if prefix is c or v.
Fix some bugs regarding regular expression parsing in javascript.
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.