Skip to content

Move tap configuration to avoid duplicate calls#1303

Merged
dvoytenko merged 1 commit intoampproject:masterfrom
dvoytenko:action-fix
Jan 5, 2016
Merged

Move tap configuration to avoid duplicate calls#1303
dvoytenko merged 1 commit intoampproject:masterfrom
dvoytenko:action-fix

Conversation

@dvoytenko
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make an installEvents method, so the caller doesn't need to know about what is being installed?

@cramforce
Copy link
Copy Markdown
Member

LGTM

dvoytenko added a commit that referenced this pull request Jan 5, 2016
Move tap configuration to avoid duplicate calls
@dvoytenko dvoytenko merged commit f4ba611 into ampproject:master Jan 5, 2016
@dvoytenko dvoytenko deleted the action-fix branch January 5, 2016 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants