point out that localhost urls are also fine#1179
Merged
dvoytenko merged 1 commit intoampproject:masterfrom Jan 4, 2016
Merged
Conversation
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 4b628af (Please note that this is a fully automated comment.) |
Contributor
|
LGTM. Thanks! |
dvoytenko
added a commit
that referenced
this pull request
Jan 4, 2016
point out that localhost urls are also fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the error message we can't use relative urls, but if it were localhost it would be fine. Since when developing locally we often use www.thegulocal.com as a convention for localhost, it would be better to point out the problem in the message.
It would actually be better to allow relative urls, but it would require the google cache to make a note of the original hostname when rewriting the URLs. If you could do that, it would be ideal.