Do not close lightbox on tap#1327
Merged
camelburrito merged 1 commit intoampproject:masterfrom Jan 7, 2016
Merged
Conversation
Member
|
Please update the PR description to say what this change does and then add something like fixes #1274, since this change seems to in practice do something very different, right? Seems like it removes an undesirable feature. Done! |
Contributor
|
LGTM |
camelburrito
pushed a commit
that referenced
this pull request
Jan 7, 2016
Do not close lightbox on tap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not close lightbox on tap as it is not supported in the spec and also causes #1274
see https://github.com/ampproject/amphtml/blob/master/extensions/amp-lightbox/amp-lightbox.md#closing-the-lightbox - for help on closing a lightbox