Use travis_retry on PHPUnit for external-http tests#4298
Merged
westonruter merged 3 commits intodevelopfrom Feb 15, 2020
Merged
Use travis_retry on PHPUnit for external-http tests#4298westonruter merged 3 commits intodevelopfrom
westonruter merged 3 commits intodevelopfrom
Conversation
westonruter
requested changes
Feb 15, 2020
Member
westonruter
left a comment
There was a problem hiding this comment.
There is another external job this needs to be done for: "PHP unit tests w/ external-http (5.6, WordPress 4.9)"
westonruter
reviewed
Feb 15, 2020
westonruter
approved these changes
Feb 15, 2020
westonruter
pushed a commit
that referenced
this pull request
Feb 15, 2020
* Use travis_retry on PHPUnit for external-http tests * Add travis_retry to second external-http suite as well * Refactor travis external-http setup
westonruter
added a commit
that referenced
this pull request
Feb 16, 2020
…ued-dependency-sourcing * 'develop' of github.com:ampproject/amp-wp: (124 commits) Copy patches folder when building Re-run amphtml-update.sh to remove duplicate Use travis_retry on PHPUnit for external-http tests (#4298) Improve display of anyof/oneof attributes in details Add error code for DUPLICATE_ONEOF_ATTRS; add error messages Sort the attributes from GetMandatoryOf() Simplify amphtml-update.py, using Weston's suggestiony Improve conversion of resizable iframes and those containing placeholder/overflow Add tests Update patch Bump CSS cache group Add patch from external PR that resolves the issue In amphtml-update.py, remove extra spaces inside function Rename method to get_unsatisfied_number_of_rule() Add more unit tests, including allowed mandatory_*of Update the PHP logic for the changed mandator_*of in the spec Move the mandatory_*of rule to the 'tag_spec' Bump stable tag to 1.4.3 Update readme and screenshots for Stories removal (#4259) Update dependency @wordpress/core-data to v2.12.0 (#4265) ...
Member
|
It doesn't seem like this is working. I see no retrying: https://travis-ci.org/ampproject/amp-wp/jobs/651618798#L1134 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The test suite external-http can fail for occasional and random network issues.
This PR uses
travis_retryto run PHPUnit for this test-suite, so that an occasional hiccup will be ignored in most cases because a subsequent retry will succeed.Fixes #4187
Checklist