Bump amp-custom style size limit from 50000 to 75000 bytes#4313
Merged
westonruter merged 1 commit intodevelopfrom Feb 18, 2020
Merged
Bump amp-custom style size limit from 50000 to 75000 bytes#4313westonruter merged 1 commit intodevelopfrom
westonruter merged 1 commit intodevelopfrom
Conversation
22cfca1 to
90ff57a
Compare
amedina
approved these changes
Feb 18, 2020
Member
amedina
left a comment
There was a problem hiding this comment.
Yes! Excellent to see this land.
westonruter
added a commit
that referenced
this pull request
Feb 18, 2020
swissspidy
reviewed
Feb 20, 2020
| sprintf( | ||
| /* translators: 1: Documentation URL, 2: Documentation URL, 3: !important */ | ||
| __( 'AMP allows you to <a href="%1$s">style your pages using CSS</a> in much the same way as regular HTML pages, however there are some <a href="%2$s">restrictions</a>. Nevertheless, the AMP plugin automatically inlines external stylesheets, transforms %3$s qualifiers, and uses tree shaking to remove the majority of CSS rules that do not apply to the current page. Nevertheless, AMP does have a 50KB limit and tree shaking cannot always reduce the amount of CSS under this limit; when this happens an excessive CSS error will result.', 'amp' ), | ||
| __( 'AMP allows you to <a href="%1$s">style your pages using CSS</a> in much the same way as regular HTML pages, however there are some <a href="%2$s">restrictions</a>. Nevertheless, the AMP plugin automatically inlines external stylesheets, transforms %3$s qualifiers, and uses tree shaking to remove the majority of CSS rules that do not apply to the current page. Nevertheless, AMP does have a 75KB limit and tree shaking cannot always reduce the amount of CSS under this limit; when this happens an excessive CSS error will result.', 'amp' ), |
Collaborator
There was a problem hiding this comment.
@westonruter Using a placeholder for the limit here would make the string more future-proof, just an idea.
Member
Author
There was a problem hiding this comment.
Yes, I thought about that. However, it is extremely unlikely the limit will be changed again. So that's why I didn't bother.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See ampproject/amphtml#26466 and ampproject/amphtml#26475.
This PR directly patches
class-amp-allowed-tags-generated.phpwithout updating the entire spec which will include a lot of other changes. This will facilitate a little 1.4.4 release with a big impact.The validator update has been deployed:
Checklist