Skip to content

Simplify Stories removal notice text#4314

Merged
westonruter merged 1 commit intodevelopfrom
amedina/stories-notice
Feb 19, 2020
Merged

Simplify Stories removal notice text#4314
westonruter merged 1 commit intodevelopfrom
amedina/stories-notice

Conversation

@amedina
Copy link
Copy Markdown
Member

@amedina amedina commented Feb 19, 2020

Summary

Simplify the message given to users after the Stories experience has been removed. This is the case for users that did not have stories created prior to the removal.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@amedina amedina requested a review from westonruter February 19, 2020 00:10
@googlebot
Copy link
Copy Markdown

googlebot commented Feb 19, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Has not signed the Google CLA label Feb 19, 2020
@amedina amedina force-pushed the amedina/stories-notice branch from a7723bf to 96484a2 Compare February 19, 2020 00:51
@amedina amedina added the cla: yes Signed the Google CLA label Feb 19, 2020
@googlebot
Copy link
Copy Markdown

googlebot commented Feb 19, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot googlebot removed the cla: no Has not signed the Google CLA label Feb 19, 2020
@amedina amedina removed the cla: yes Signed the Google CLA label Feb 19, 2020
@googlebot
Copy link
Copy Markdown

googlebot commented Feb 19, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Has not signed the Google CLA label Feb 19, 2020
@amedina amedina added cla: yes Signed the Google CLA and removed cla: no Has not signed the Google CLA labels Feb 19, 2020
@googlebot
Copy link
Copy Markdown

googlebot commented Feb 19, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

westonruter
westonruter requested changes Feb 19, 2020
View reviewed changes
includes/options/class-amp-options-manager.php Outdated
printf(
'<div class="notice notice-info"><p>%s</p></div>',
esc_html__( 'The Stories experience has been removed from the AMP plugin. This beta feature is being split into a separate standalone plugin which will be available for installation soon.', 'amp' )
esc_html__( 'The Stories experience [beta] has been split into a standalone plugin which will be available soon.', 'amp' )
Copy link
Copy Markdown
Member

@westonruter westonruter Feb 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one more instance of this string in the render_stories_deprecation_editor_notice() method.

Copy link
Copy Markdown
Member

@westonruter westonruter Feb 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or rather, perhaps two?

amp-wp/includes/options/class-amp-options-manager.php

Line 596 in e42d45a

esc_html__( 'The Stories experience is being extracted from the AMP plugin into a separate standalone plugin which will be available soon. Please back up or export your existing Stories as they will not be available in the next version of the AMP plugin.', 'amp' ),

amp-wp/includes/options/class-amp-options-manager.php

Line 631 in e42d45a

wp_json_encode( __( 'The Stories experience is being extracted from the AMP plugin into a separate standalone plugin which will be available soon. Please back up or export your existing Stories as they will not be available in the next version of the AMP plugin.', 'amp' ) ),

Copy link
Copy Markdown
Collaborator

@swissspidy swissspidy Feb 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would strongly advocate for removing the [beta] part from this string.

Also, I would unify the strings. Now there are "has been split" and "is being split"

Copy link
Copy Markdown
Member Author

@amedina amedina Feb 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@googlebot
Copy link
Copy Markdown

googlebot commented Feb 19, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Has not signed the Google CLA and removed cla: yes Signed the Google CLA labels Feb 19, 2020
@amedina amedina force-pushed the amedina/stories-notice branch from e42d45a to 62a7ed5 Compare February 19, 2020 16:37
@amedina amedina force-pushed the amedina/stories-notice branch from 62a7ed5 to f73a063 Compare February 19, 2020 16:39
@amedina amedina added cla: yes Signed the Google CLA and removed cla: no Has not signed the Google CLA labels Feb 19, 2020
@googlebot
Copy link
Copy Markdown

googlebot commented Feb 19, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@westonruter westonruter added this to the v1.4.4 milestone Feb 19, 2020
@westonruter westonruter merged commit 6ec20fa into develop Feb 19, 2020
@westonruter westonruter deleted the amedina/stories-notice branch February 19, 2020 19:12
westonruter pushed a commit that referenced this pull request Feb 19, 2020
@amedina @westonruter
Simplify notice text for Stories removal (#4314)
52133f4
westonruter added a commit that referenced this pull request Feb 19, 2020
@westonruter
Merge tag '1.4.4'
1126a0e 
* tag '1.4.4':
  Bump 1.4.4
  Simplify notice text for Stories removal (#4314)
  Bump amp-custom style limit from 50000 to 75000 bytes (#4313)
  Use travis_retry on PHPUnit for external-http tests (#4298)
  Bump version to 1.4.4-alpha
  Bump 1.4.3
@swissspidy swissspidy mentioned this pull request Feb 20, 2020
Merged
6 tasks
westonruter added a commit that referenced this pull request Feb 24, 2020
@westonruter
Merge branch 'develop' of github.com:ampproject/amp-wp into fix/relat…
4a08b95 
…ive-stylesheet-urls

* 'develop' of github.com:ampproject/amp-wp: (23 commits)
  Bump stable tag to 1.4.4
  Simplify notice text for Stories removal (#4314)
  Update composer.lock
  Bump amp-custom style limit from 50000 to 75000 bytes
  Update composer.lock
  Update wp-cli/wp-cli to v2.4.1
  Revert "Ignore wp-cli/wp-cli patch for mustache/mustache"
  Update dependency svg-inline-loader to v0.8.2 (#4302)
  Update dependency @wordpress/editor to v9.12.1 (#4306)
  Update dependency @wordpress/server-side-render to v1.8.1 (#4308)
  Update dependency @wordpress/nux to v3.12.1 (#4307)
  Update dependency @wordpress/edit-post to v3.13.1 (#4305)
  Update dependency @wordpress/components to v9.2.1 (#4304)
  Update dependency @wordpress/block-editor to v3.7.1 (#4303)
  Update dependency postcss to v7.0.27 (#4309)
  Update dependency browserslist to v4.8.7 (#4287)
  Update dependency terser-webpack-plugin to v2.3.5 (#4291)
  Update dependency sirbrillig/phpcs-variable-analysis to v2.8.1
  Ignore wp-cli/wp-cli patch for mustache/mustache
  Add test
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy left review comments

@westonruter westonruter westonruter approved these changes

Assignees

No one assigned

Labels

cla: yes Signed the Google CLA

Projects

None yet

Milestone

v1.4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@amedina @googlebot @westonruter @swissspidy