Update readme and screenshots for Stories removal#4259
Merged
westonruter merged 1 commit intodevelopfrom Feb 13, 2020
Merged
Conversation
amedina
approved these changes
Feb 13, 2020
Member
amedina
left a comment
There was a problem hiding this comment.
Looks pretty good! I love the refocus of the plugin on AMP-first again.
westonruter
added a commit
that referenced
this pull request
Feb 13, 2020
westonruter
added a commit
that referenced
this pull request
Feb 13, 2020
* tag '1.4.3': (22 commits) Update readme and screenshots for Stories removal (#4259) Open story export instructions in a new window (#4258) Bump version to 1.4.3-RC1 Hide Stories options and add deprecation notice (#4219) Fix malformed conversion of relative action URLs for forms (#4250) Limit Stories experience to WP 5.3 & Gutenberg 7.1.0 (#4217) Prevent errors in admin bar filters from non-array arguments (#4207) Update @wordpress/e2e-test-utils dependency Revert update of mustache/mustache dependency Update composer.lock Update WP CLI to 2.4.0 For WordPress.tv embed, Use an oembed filter instead of block filter (#4164) Update readme to add FAQs section (#4159) Apply workaround to fix test__multiple_valid_image_files (#4034) Ignore Story editor tests (#4043) Update amp-video embed regex pattern to include other Vimeo URL formats (#4051) Update amp-instagram embed regex (#4053) Update wp-dev-lib package (#4029) Fix conversion of forms with relative action URLs (#4003) Improve release instructions (#3995) ...
westonruter
added a commit
that referenced
this pull request
Feb 16, 2020
…ued-dependency-sourcing * 'develop' of github.com:ampproject/amp-wp: (124 commits) Copy patches folder when building Re-run amphtml-update.sh to remove duplicate Use travis_retry on PHPUnit for external-http tests (#4298) Improve display of anyof/oneof attributes in details Add error code for DUPLICATE_ONEOF_ATTRS; add error messages Sort the attributes from GetMandatoryOf() Simplify amphtml-update.py, using Weston's suggestiony Improve conversion of resizable iframes and those containing placeholder/overflow Add tests Update patch Bump CSS cache group Add patch from external PR that resolves the issue In amphtml-update.py, remove extra spaces inside function Rename method to get_unsatisfied_number_of_rule() Add more unit tests, including allowed mandatory_*of Update the PHP logic for the changed mandator_*of in the spec Move the mandatory_*of rule to the 'tag_spec' Bump stable tag to 1.4.3 Update readme and screenshots for Stories removal (#4259) Update dependency @wordpress/core-data to v2.12.0 (#4265) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the readme to update references to Stories by mostly removing them.
There is new line added explaining where Stories went and when the feature will be available again in a new standalone plugin.
It also removes two screenshots, namely:
It then also updates screenshot 3 (which is now screenshot 4):
This PR is in draft because the copy in the screenshot is pending final review. (They will be used as slides in WordCamp Asia.)For easy comparison of the changes, preview:
Before: https://github.com/ampproject/amp-wp/blob/1.4.2/readme.md
After: https://github.com/ampproject/amp-wp/blob/update/readme-stories/readme.md
Relates to #4201 and #4202.
Checklist