Open story export instructions in a new window#4258
Merged
westonruter merged 1 commit intodevelopfrom Feb 9, 2020
Merged
Conversation
Member
Author
I see no way to open editor notices in a new window: |
Contributor
|
@westonruter Here's one way to open a new window in the editor: --- includes/options/class-amp-options-manager.php (revision f77530f809c88cea6310d3d669119e0a710e3b8b)
+++ includes/options/class-amp-options-manager.php (date 1581284825580)
@@ -621,8 +621,9 @@
isDismissible: false,
actions: [
{
- url: 'https://amp-wp.org/documentation/amp-stories/exporting-stories/',
label: %s,
+ className: 'is-link', // to make the <button> look like a link
+ onClick: () => window.open(\"https://amp-wp.org/documentation/amp-stories/exporting-stories/\")
},
],
} |
|
Verified in QA |
westonruter
added a commit
that referenced
this pull request
Feb 13, 2020
* tag '1.4.3': (22 commits) Update readme and screenshots for Stories removal (#4259) Open story export instructions in a new window (#4258) Bump version to 1.4.3-RC1 Hide Stories options and add deprecation notice (#4219) Fix malformed conversion of relative action URLs for forms (#4250) Limit Stories experience to WP 5.3 & Gutenberg 7.1.0 (#4217) Prevent errors in admin bar filters from non-array arguments (#4207) Update @wordpress/e2e-test-utils dependency Revert update of mustache/mustache dependency Update composer.lock Update WP CLI to 2.4.0 For WordPress.tv embed, Use an oembed filter instead of block filter (#4164) Update readme to add FAQs section (#4159) Apply workaround to fix test__multiple_valid_image_files (#4034) Ignore Story editor tests (#4043) Update amp-video embed regex pattern to include other Vimeo URL formats (#4051) Update amp-instagram embed regex (#4053) Update wp-dev-lib package (#4029) Fix conversion of forms with relative action URLs (#4003) Improve release instructions (#3995) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Amends #4219; see #4202.
Checklist