Consent events delivery, collect consent enforcement and updated dependencies from Identity to Edge Identity by emdobrin · Pull Request #173 · adobe/aepsdk-edge-ios

emdobrin · 2021-03-24T18:27:46Z

Description

The Edge extension now enforces the collect consent settings when Consent extension is registered as follows:
- When collect consent is yes, the experience events are collected and sent to the Edge Network.
- When collect consent is no, the experience events are dropped and not processed. Any previously persisted events that were not sent yet will also be dropped.
- When collect consent is pending or other unknown value, the experience events are collected and held in persistence until the collect consent settings change to yes or no.
- When consent extension is not registered the default collect consent yes will be used.
The Edge extension drops support for privacy status settings in favor of collect consent settings.
Adds support for consent events delivery to the Edge Network when using the Consent extension and updating the consent preferences.
The Edge extension has a hard dependency on Edge Identity extension and does not depend on Identity extension anymore.
The persisted events now include the identityMap at the time of event queuing.

Related Issue

Motivation and Context

How Has This Been Tested?

Unit and functional testing, as well as integration testing with Consent and Edge Identity extensions.
Update test app with the new dependencies.

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

[AMSDK-11013] Support for sending update consent requests to Edge Network

* Read XDM shared state from IdentityEdge * Remove unused constant * Fix functional tests * Add IdentityEdge to podspec dependencies * Remove IdentityMap in favor of dictionary * Remove AEPIdentityEdge from dependency * Get tests passing * Use constant * Fix testProcessHit_noECID test * Dynamic encoding for XDM payloads * DynamicKey -> DynamicCodingKey * Update consent hit to use free form dict * Use constant for identityMap * Consolidate line * Use "test-ecid" * Add test helper for building identity map * Update to latest identity edge * Remove request context data * Read only IdentityMap from Identity XDM shared state

…sent (#166) * Implement collect consent, remove privacy status * update dependencies, fix test compile error * format * sample app updates for consent + identityedge * Remove privacy status tests and add tests for events queing with consent * Functional tests for Consent use-cases * Mock classes for dataQueue, hitProcessor, unit tests for Edge extension class * Set initial queue state, docs * fix docs, update pods * review impl

* Update Identity and Consent after extension renames * Remove Consent shared state name as it is not used. * Add Consent to list of test caches to clear * Update Consent shared state name

* Add EdgeDataEntity and persist identityMap and store payloads * Filter out expired payloads before sending hit * Handle reset event * Add tests * Add empty event data check to hit processor for experience and consent events * lint * Store tuples of uuid's and dates instead of entire event * Make date in network handler thread safe and update logs * Extract ignoreStorePayloads to a functino * Add comment about batching * Add functional tests for clearing state store * Add atomic test * clean up test for atomic * Update comments, add log

* Renaming and update dependencies * Update dependencies * Update identity integration tests to primary false

codecov · 2021-03-24T20:57:23Z

Codecov Report

Merging #173 (4828306) into dev (bf0cb75) will increase coverage by 0.89%.
The diff coverage is 94.10%.

@@            Coverage Diff             @@
##              dev     #173      +/-   ##
==========================================
+ Coverage   93.20%   94.09%   +0.89%     
==========================================
  Files          20       25       +5     
  Lines         721      880     +159     
==========================================
+ Hits          672      828     +156     
- Misses         49       52       +3

* Fix log * Update NetworkResponseHandler.swift

#176) * Check for consent registration based on hub shared state * [AMSDK-11328] Consts, improve readability

* Enable response streaming for Consent requests. * Add tests to verify streaming config in Consent requests

Sources/EdgeNetworkHandlers/NetworkResponseHandler.swift

emdobrin · 2021-03-29T19:11:17Z

Sources/EdgeNetworkHandlers/EdgeHitProcessor.swift

-        guard let data = entity.data, let event = try? JSONDecoder().decode(Event.self, from: data) else {
+        guard let data = entity.data, let edgeEntity = try? JSONDecoder().decode(EdgeDataEntity.self, from: data)


We may need to perform some migration logic for previously persisted hits.

* persist last known reset timestamp * Fix test * Return nil when loading from persistence, change constant name * Add +/- to testing dates

emdobrin and others added 21 commits February 1, 2021 12:07

Handle consent update events, send network request

fe35423

Update shouldIgnore for consent

ea58bfc

Updated unit tests with latest network service APIs format

3900647

Unit tests for EdgeHitProcessor with consent

f794259

Update eventSource to updateConsent and Sample app updates

f7c7c75

cleanup

b3e60cb

Cleanup

9a7da99

Add helpers for checking event type

54a6339

update eventsource for tests

1fdc55d

disable swiftlint rules for tests

bbe4c2d

Register instrumented extension without core start

3b429dc

Start MobileCore in NetworkResponseHandler tests

58b2e52

Create new files for EdgeHit implementations and pod update

400b9ec

Fix the read from consent shared state

495178b

Merge pull request #164 from emdobrin/consent

e8e8330

[AMSDK-11013] Support for sending update consent requests to Edge Network

Update Identity and Consent after extension renames (#167)

42c7db2

* Update Identity and Consent after extension renames * Remove Consent shared state name as it is not used. * Add Consent to list of test caches to clear * Update Consent shared state name

Renaming and update dependencies (#171)

034d831

* Renaming and update dependencies * Update dependencies * Update identity integration tests to primary false

Add consent update event to waiting events list (#174)

2ccec67

nporter-adbe and others added 3 commits March 25, 2021 09:17

Fix log on ignore payloads (#175)

6ec9912

* Fix log * Update NetworkResponseHandler.swift

[AMSDK-11328] Check for consent registration based on hub shared state (

a523a77

#176) * Check for consent registration based on hub shared state * [AMSDK-11328] Consts, improve readability

Enable response streaming for Consent update events (#177)

8298213

* Enable response streaming for Consent requests. * Add tests to verify streaming config in Consent requests

emdobrin commented Mar 29, 2021

View reviewed changes

[AMSDK-11384] Persist reset timestamp (#178)

4828306

* persist last known reset timestamp * Fix test * Return nil when loading from persistence, change constant name * Add +/- to testing dates

PravinPK approved these changes Mar 30, 2021

View reviewed changes

emdobrin merged commit dfdab79 into dev Mar 30, 2021

emdobrin added the feature Adds a new feature label Jan 6, 2022

kevinlind deleted the feature/consent branch October 20, 2022 03:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consent events delivery, collect consent enforcement and updated dependencies from Identity to Edge Identity#173

Consent events delivery, collect consent enforcement and updated dependencies from Identity to Edge Identity#173
emdobrin merged 25 commits intodevfrom
feature/consent

emdobrin commented Mar 24, 2021 •

edited

Loading

Uh oh!

codecov bot commented Mar 24, 2021 •

edited

Loading

Uh oh!

Uh oh!

emdobrin Mar 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		guard let data = entity.data, let event = try? JSONDecoder().decode(Event.self, from: data) else {
		guard let data = entity.data, let edgeEntity = try? JSONDecoder().decode(EdgeDataEntity.self, from: data)

Conversation

emdobrin commented Mar 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

codecov bot commented Mar 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

emdobrin Mar 29, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

emdobrin commented Mar 24, 2021 •

edited

Loading

codecov bot commented Mar 24, 2021 •

edited

Loading