[AMSDK-11384] Persist reset timestamp#178
Merged
nporter-adbe merged 4 commits intoadobe:feature/consentfrom Mar 29, 2021
Merged
[AMSDK-11384] Persist reset timestamp#178nporter-adbe merged 4 commits intoadobe:feature/consentfrom
nporter-adbe merged 4 commits intoadobe:feature/consentfrom
Conversation
10 tasks
Codecov Report
@@ Coverage Diff @@
## feature/consent #178 +/- ##
===================================================
+ Coverage 94.04% 94.09% +0.05%
===================================================
Files 25 25
Lines 873 880 +7
===================================================
+ Hits 821 828 +7
Misses 52 52 |
emdobrin
reviewed
Mar 29, 2021
| class NetworkResponseHandler { | ||
| private let LOG_TAG = "NetworkResponseHandler" | ||
| private let serialQueue = DispatchQueue(label: "com.adobe.edge.eventsDictionary") // serial queue for atomic operations | ||
| private let dataStore = NamedCollectionDataStore(name: EdgeConstants.EXTENSION_NAME) |
Contributor
There was a problem hiding this comment.
What do you think about moving the last reset over to StoreResponsePayloadManager as it already has access to the DataStore and this change is related to the store cleanup?
Contributor
Author
There was a problem hiding this comment.
We could do that, but given our timeline, I'd prefer not to as there is very little benefit.
kevinlind
reviewed
Mar 29, 2021
Tests/FunctionalTests/NetworkResponseHandlerFunctionalTests.swift
Outdated
Show resolved
Hide resolved
Tests/FunctionalTests/NetworkResponseHandlerFunctionalTests.swift
Outdated
Show resolved
Hide resolved
kevinlind
approved these changes
Mar 29, 2021
emdobrin
approved these changes
Mar 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Persists the last reset timestamp so we can inspect it between sessions:
https://jira.corp.adobe.com/browse/AMSDK-11384
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: