[AMSDK-11013] Support for sending update consent requests to Edge Network#164
Merged
emdobrin merged 14 commits intoadobe:feature/consentfrom Feb 18, 2021
Merged
[AMSDK-11013] Support for sending update consent requests to Edge Network#164emdobrin merged 14 commits intoadobe:feature/consentfrom
emdobrin merged 14 commits intoadobe:feature/consentfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/consent #164 +/- ##
===================================================
- Coverage 93.08% 90.95% -2.12%
===================================================
Files 20 23 +3
Lines 621 807 +186
===================================================
+ Hits 578 734 +156
- Misses 43 73 +30 |
|
|
||
| func getPayload() -> String? { | ||
| let encoder = JSONEncoder() | ||
| encoder.outputFormatting = [.prettyPrinted] |
Contributor
There was a problem hiding this comment.
Any reason why this needs to be pretty printed?
Contributor
Author
There was a problem hiding this comment.
The request payload is also printed to debug logs.
PravinPK
approved these changes
Feb 17, 2021
kevinlind
approved these changes
Feb 17, 2021
Contributor
kevinlind
left a comment
There was a problem hiding this comment.
Looks good. Added a comment, but doesn't require changes for this PR.
| /// An `EdgeConsentUpdate` is the top-level request object sent to Experience Edge to the set-consent endpoint. | ||
| struct EdgeConsentUpdate: Encodable { | ||
| /// The IdentityMap at the moment of this request | ||
| let identityMap: IdentityMap? |
Contributor
There was a problem hiding this comment.
nit: I think this is okay for now, in this PR, however when Edge reads the IdentityEdge XDM shared state, we should remove the IdentityMap class from Edge and use a [String: Any] type here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Unit and manual testing, functional tests should be covered in a separate PR
Screenshots (if appropriate):
Types of changes
Checklist: