Skip to content

Fix log on ignore payloads#175

Merged
nporter-adbe merged 2 commits intofeature/consentfrom
nporter-adbe-patch-1
Mar 25, 2021
Merged

Fix log on ignore payloads#175
nporter-adbe merged 2 commits intofeature/consentfrom
nporter-adbe-patch-1

Conversation

@nporter-adbe
Copy link
Copy Markdown
Contributor

No description provided.

@nporter-adbe nporter-adbe requested a review from emdobrin March 24, 2021 22:22
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2021

Codecov Report

Merging #175 (3e36884) into feature/consent (2ccec67) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           feature/consent     #175      +/-   ##
===================================================
+ Coverage            93.98%   93.99%   +0.01%     
===================================================
  Files                   25       25              
  Lines                  864      865       +1     
===================================================
+ Hits                   812      813       +1     
  Misses                  52       52              

Copy link
Copy Markdown
Contributor

@emdobrin emdobrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with a small comment on log message

let requestEventId = extractRequestEventId(forEventIndex: eventHandle.eventIndex, requestId: requestId)
if !ignoreStorePayloads {
if ignoreStorePayloads {
Log.debug(label: LOG_TAG, "Ignoring state:store payload for request with id: \(requestId)")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identities were reset recently, ignoring state:store payload for request with id: ...

@nporter-adbe nporter-adbe merged commit 6ec9912 into feature/consent Mar 25, 2021
@nporter-adbe nporter-adbe deleted the nporter-adbe-patch-1 branch April 7, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants