Update Identity and Consent after extension renames#167
Merged
emdobrin merged 4 commits intoadobe:feature/consentfrom Mar 16, 2021
Merged
Update Identity and Consent after extension renames#167emdobrin merged 4 commits intoadobe:feature/consentfrom
emdobrin merged 4 commits intoadobe:feature/consentfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/consent #167 +/- ##
================================================
Coverage 93.06% 93.06%
================================================
Files 24 24
Lines 793 793
================================================
Hits 738 738
Misses 55 55 |
emdobrin
reviewed
Mar 15, 2021
| @@ -43,7 +44,7 @@ enum FunctionalTestConst { | |||
| enum SharedState { | |||
| static let CONFIGURATION = "com.adobe.module.configuration" | |||
| static let CONSENT = "com.adobe.consent" | |||
Contributor
There was a problem hiding this comment.
this should also be: com.adobe.edge.consent
Contributor
Author
There was a problem hiding this comment.
This constant isn't actually used so I removed it.
Contributor
There was a problem hiding this comment.
this is being used in getConsentForEvent, so we need to update it in EdgeConstants
|
|
||
| func clearCache() { | ||
| let knownCacheItems: [String] = ["com.adobe.edge", "com.adobe.identityedge"] | ||
| let knownCacheItems: [String] = ["com.adobe.edge", "com.adobe.edge.identity"] |
nporter-adbe
approved these changes
Mar 16, 2021
emdobrin
approved these changes
Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update Edge with latest versions of AEPEdgeIdentity and AEPEdgeConsent after the module renaming.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: