Update CI with Ruby 3.4, fix Rails Logger constant resolution issue#328
Merged
Update CI with Ruby 3.4, fix Rails Logger constant resolution issue#328
Conversation
because the latest concurrent-ruby dropped logger as a dependency, this broke Rails's dependencies. See rails/rails#54264 for more details.
Don't run 6.1 or 7.0 with Ruby 3.4 (some missing Gems due to moving them out of the bundled set), and handle the 3.4 exception message quoting changes.
57ca3ee to
15bac4e
Compare
Collaborator
Author
|
@kbrock Can you take a look and merge this when you get a second? |
Collaborator
Author
|
@kbrock bumping! |
Collaborator
Author
|
@kbrock please approve this so I can merge, CI has been broken for months. |
kbrock
approved these changes
Apr 9, 2025
| expect { | ||
| Country.find_by_name_and_shoe_size!("US", 10) | ||
| }.to raise_error(NoMethodError, /undefined method `find_by_name_and_shoe_size!' (?:for|on) (class )?Country/) | ||
| }.to raise_error(NoMethodError, /undefined method [`']find_by_name_and_shoe_size!' (?:for|on) (class )?Country/) |
Collaborator
There was a problem hiding this comment.
hadn't realized ruby changed this.
(makes me very happy)
Collaborator
|
@flavorjones sorry Mike |
Collaborator
Author
|
@kbrock Thanks so much! ❤️ |
kbrock
added a commit
to kbrock/active_hash
that referenced
this pull request
Jul 29, 2025
- Add i18n support active-hash#230 @ryu-sato - Add `column_names` method active-hash#311 @hatsu38 - Support Active Record 7.2 active-hash#317 @ashleyHutton - Support ruby 3.4 active-hash#328 @flavorjones - Add `:alias` to `has_many :through` active-hash#329 @alexgriff - Add Active Record 8.0 active-hash#324 @flavorjones - Fix Do not suppress load errors#309 @andreynering - Ensure `field_names` are all strings active-hash#312 @flavorjones - Hide private `add_default_value` active-hash#314 @kbrock - Fix `exists?(nil)` active-hash#320 @y-yagi - Enance Enum support active-hash#321 @hatsu38 - Updated docs active-hash#326 @y-yagi - Drop Active Record < 6.1. Ruby < 3.0 active-hash#324 @flavorjones
kbrock
added a commit
to kbrock/active_hash
that referenced
this pull request
Jul 29, 2025
Added ===== - Add i18n support active-hash#230 @ryu-sato - Add `column_names` method active-hash#311 @hatsu38 - Support Active Record 7.2 active-hash#317 @ashleyHutton - Support ruby 3.4 active-hash#328 @flavorjones - Add `:alias` to `has_many :through` active-hash#329 @alexgriff - Add Active Record 8.0 active-hash#324 @flavorjones Fixed ===== - Fix Do not suppress load errors#309 @andreynering - Ensure `field_names` are all strings active-hash#312 @flavorjones - Hide private `add_default_value` active-hash#314 @kbrock - Fix `exists?(nil)` active-hash#320 @y-yagi - Enance Enum support active-hash#321 @hatsu38 - Updated docs active-hash#326 @y-yagi Removed ======= - Drop Active Record < 6.1. Ruby < 3.0 active-hash#324 @flavorjones
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.