Skip to content

Add support for a block argument on Relation#count#317

Merged
kbrock merged 1 commit intoactive-hash:masterfrom
ashleyHutton:master
Oct 28, 2024
Merged

Add support for a block argument on Relation#count#317
kbrock merged 1 commit intoactive-hash:masterfrom
ashleyHutton:master

Conversation

@ashleyHutton
Copy link
Contributor

Closes #316

This pull request adds support for a block argument in the #count method.

Copy link
Collaborator

@flavorjones flavorjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kbrock
Copy link
Collaborator

kbrock commented Oct 28, 2024

This looks good.

@kbrock kbrock merged commit fd24cd2 into active-hash:master Oct 28, 2024
kbrock added a commit to kbrock/active_hash that referenced this pull request Jul 29, 2025
- Add i18n support active-hash#230 @ryu-sato
- Add `column_names` method active-hash#311 @hatsu38
- Support Active Record 7.2 active-hash#317 @ashleyHutton
- Support ruby 3.4 active-hash#328 @flavorjones
- Add `:alias` to `has_many :through` active-hash#329 @alexgriff
- Add Active Record 8.0 active-hash#324 @flavorjones

- Fix Do not suppress load errors#309 @andreynering
- Ensure `field_names` are all strings active-hash#312 @flavorjones
- Hide private `add_default_value` active-hash#314 @kbrock
- Fix `exists?(nil)` active-hash#320 @y-yagi
- Enance Enum support active-hash#321 @hatsu38
- Updated docs active-hash#326 @y-yagi

- Drop Active Record < 6.1. Ruby < 3.0 active-hash#324 @flavorjones
kbrock added a commit to kbrock/active_hash that referenced this pull request Jul 29, 2025
Added
=====

- Add i18n support active-hash#230 @ryu-sato
- Add `column_names` method active-hash#311 @hatsu38
- Support Active Record 7.2 active-hash#317 @ashleyHutton
- Support ruby 3.4 active-hash#328 @flavorjones
- Add `:alias` to `has_many :through` active-hash#329 @alexgriff
- Add Active Record 8.0 active-hash#324 @flavorjones

Fixed
=====

- Fix Do not suppress load errors#309 @andreynering
- Ensure `field_names` are all strings active-hash#312 @flavorjones
- Hide private `add_default_value` active-hash#314 @kbrock
- Fix `exists?(nil)` active-hash#320 @y-yagi
- Enance Enum support active-hash#321 @hatsu38
- Updated docs active-hash#326 @y-yagi

Removed
=======

- Drop Active Record < 6.1. Ruby < 3.0 active-hash#324 @flavorjones
@kbrock kbrock mentioned this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

count should support a block

3 participants