Ensure the logger gem is loaded in Rails 7.0#54264
Ensure the logger gem is loaded in Rails 7.0#54264fatkodima merged 1 commit intorails:7-0-stablefrom
Conversation
760cdbe to
6a7c72c
Compare
|
Dearest Rails core team, I know how annoying this is, but can this commit be released on RubyGems? It's breaking all test suites that rely on a working Rails 7.0... |
You can point to the 7-0-stable branch. Rails 7.0 isn't supported anymore for bug fixes, so a release including that change is very unlikely https://rubyonrails.org/maintenance |
|
You can also:
etc. edit: |
Temporary pin down as concurrent-ruby 1.3.5 breaks Rails 7.0, and rails-core doesn't plan to ship a new 7.0 to fix it. See rails/rails#54264
v1.3.5 no longer loads the logger gem. This breaks ActiveSupport. See rails/rails#54264
1.3.5 introduced a change that broke activesupport (and so middleman, which uses it). It might be to do with it dropping Logger as a dependency but this is unclear. Full release notes are: https://github.com/ruby-concurrency/concurrent-ruby/releases/tag/v1.3.5 The activesupport gem fixed this in v7-0-stable of Rails: rails/rails#54264 So we're waiting for middleman to pull that version in. They have an issue for this: middleman/middleman#2788
…m which breaks the internal logic of the ActiveSupport::LoggerThreadSafeLevel module, so require `logger` as early as possible. See rails/rails#54264 (comment)
You're right, it explicitly needs to be required before Active Support and Maybe the best place would be in |
Motivation / Background
This Pull Request has been created because the
concurrent-rubygem's version 1.3.5 no longer loads theloggergem which breaks the internal logic of theActiveSupport::LoggerThreadSafeLevelmodule.This relates to the following commit in the
concurrent-rubygem included in version 1.3.5: ruby-concurrency/concurrent-ruby@d7ce956Detail
This Pull Request changes the assumption that
concurrent-rubyloads theloggergem.Additional information
Fixes #54260
Fixes #54263
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]concurrent-ruby