Skip to content

fix(spec)!: Standardize spelling of "canceled" to use American Spelling throughout#1283

Merged
holtskinner merged 16 commits intoa2aproject:mainfrom
madankumarpichamuthu:fix/1270-standardize-cancelled-spelling
Jan 29, 2026
Merged

fix(spec)!: Standardize spelling of "canceled" to use American Spelling throughout#1283
holtskinner merged 16 commits intoa2aproject:mainfrom
madankumarpichamuthu:fix/1270-standardize-cancelled-spelling

Conversation

@madankumarpichamuthu
Copy link
Copy Markdown
Contributor

@madankumarpichamuthu madankumarpichamuthu commented Dec 5, 2025

Fixes inconsistent spelling of cancel-related terms across the specification and documentation. The proto definition uses TASK_STATE_CANCELLED (double 'l'), but various documentation files were using single 'l' spelling.

Changes:

  • cancelled → canceled
  • cancellable → cancelable
  • TaskNotCancellableErrorTaskNotCancelableError

Files modified:

  • docs/specification.md
  • docs/llms.txt
  • docs/topics/life-of-a-task.md

All documentation now consistently uses single 'l' to match the proto definition and JSON naming conventions.

Fixes #1270

Release-As: 1.0.0

… documentation

Fixes inconsistent spelling of cancel-related terms across the specification
and documentation. The proto definition uses TASK_STATE_CANCELLED (double 'l'),
but various documentation files were using single 'l' spelling.

Changes:
- canceled → cancelled (11 instances across 3 files)
- cancelable → cancellable (4 instances across 2 files)
- TaskNotCancelableError → TaskNotCancellableError (4 instances across 2 files)
- URL: task-not-cancelable → task-not-cancellable (1 instance)

Files modified:
- docs/specification.md
- docs/llms.txt
- docs/topics/life-of-a-task.md

All documentation now consistently uses British English spelling (double 'l')
to match the proto definition and JSON naming conventions.

Fixes a2aproject#1270
@madankumarpichamuthu madankumarpichamuthu requested review from a team as code owners December 5, 2025 22:25
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @madankumarpichamuthu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a spelling inconsistency within the project's documentation and specification. It standardizes the use of 'cancelled' (with double 'l') and 'cancellable' throughout various files, ensuring alignment with the existing TASK_STATE_CANCELLED proto definition and JSON naming conventions. This change improves clarity and uniformity across the project's descriptive content.

Highlights

  • Spelling Standardization: Consistently updated 'canceled' to 'cancelled' and 'cancelable' to 'cancellable' across the documentation to match proto definitions.
  • Error Name Alignment: Renamed TaskNotCancelableError to TaskNotCancellableError to align with the new spelling convention.
  • URL Path Consistency: Modified the URL path task-not-cancelable to task-not-cancellable for uniformity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively standardizes the spelling of 'cancelled' and 'cancellable' across the documentation, which improves consistency and aligns with the proto definitions. The changes are well-contained and address the issue described. I've found one minor typo in the process, which I've commented on.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@holtskinner
Copy link
Copy Markdown
Member

I think we should consolidate on the American spelling (and update the spec itself)

In 0.3.0, only one of these British spellings (Cancelled) is used in the grpc spec

TASK_STATE_CANCELLED = 5;

Every other usage, including in JSON-RPC uses the American spelling.

"canceled",

We'll have to have at least one breaking change, but I think it's best to consolidate into the American spelling to have as few as possible. (Canceled, cancelable)

What do you think @darrelmiller ?

Fixes markdown linting errors (MD060) introduced by longer spelling variant.
The change from 'TaskNotCancelableError' to 'TaskNotCancellableError' added
characters to both the error name and description text.

Changes:
- Line 570: Added 1 space after error name, removed space before '(e.g.,'
- Line 1162: Added 1 space after error name and at end of URL column

This ensures all table pipes remain vertically aligned with the header row,
satisfying markdownlint's MD060 table alignment requirements.

Related to a2aproject#1270

Author: Madan Kumar Pichamuthu
@madankumarpichamuthu madankumarpichamuthu force-pushed the fix/1270-standardize-cancelled-spelling branch from 1d725f3 to 88235d1 Compare December 11, 2025 21:06
Copy link
Copy Markdown
Member

@muscariello muscariello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madankumarpichamuthu can you please use American English spelling?

@darrelmiller
Copy link
Copy Markdown
Contributor

I have no opinion which option we use. I only care about consistency. The sentiment seems to be towards the US English, so let's do that.

@darrelmiller
Copy link
Copy Markdown
Contributor

@muscariello to update to just fix the one place where we have a double l. And then we are good to merge.

Copy link
Copy Markdown
Member

@muscariello muscariello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holtskinner
Copy link
Copy Markdown
Member

I have no opinion which option we use. I only care about consistency. The sentiment seems to be towards the US English, so let's do that.

Based on this, all of the spelling should be back to single-l, not double-l as it currently is. We also have to make sure the actual spec proto is set that way.

@darrelmiller
Copy link
Copy Markdown
Contributor

darrelmiller commented Jan 29, 2026

@muscariello or @madankumarpichamuthu Can you make them single l instead of double ll?

@muscariello
Copy link
Copy Markdown
Member

muscariello commented Jan 29, 2026

Let me do a pass. I got confused probably ... my fault I asked an Englishman..

Signed-off-by: Luca Muscariello <muscariello@ieee.org>
@muscariello
Copy link
Copy Markdown
Member

@holtskinner could you please check again ? I think I covered all the British english spelling left.

@holtskinner holtskinner changed the title docs(spec): Standardize spelling to 'cancelled' and 'cancellable' throughout… docs(spec): Standardize spelling of "canceled" to use American Spelling throughout Jan 29, 2026
@holtskinner
Copy link
Copy Markdown
Member

holtskinner commented Jan 29, 2026

Updated a couple more.

@holtskinner holtskinner changed the title docs(spec): Standardize spelling of "canceled" to use American Spelling throughout fix(spec): Standardize spelling of "canceled" to use American Spelling throughout Jan 29, 2026
@holtskinner holtskinner changed the title fix(spec): Standardize spelling of "canceled" to use American Spelling throughout fix(spec)!: Standardize spelling of "canceled" to use American Spelling throughout Jan 29, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes the spelling of "cancel"-related terms to American English ("canceled", "cancelable"), which is consistent with the PR title. The changes are mostly correct. However, the pull request description is inaccurate and should be updated to reflect the actual changes. For instance, it states "canceled → cancelled", but the changes are the other way around. Additionally, the change from TASK_STATE_CANCELLED to TASK_STATE_CANCELED in specification/grpc/a2a.proto is a breaking change for API consumers and should be highlighted as such. I've also found a minor typo in the documentation.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@holtskinner
Copy link
Copy Markdown
Member

@gemini-code-assist review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes the spelling of 'cancel'-related terms to the American English spelling ('canceled') across the specification documents and the gRPC proto definition. The changes are consistent and correctly apply the intended spelling. The update to TASK_STATE_CANCELLED in the proto file is a breaking change, which is appropriately marked in the pull request title. My review includes one minor suggestion to restore a space in the documentation for better readability.

@holtskinner holtskinner enabled auto-merge (squash) January 29, 2026 15:47
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully standardizes the spelling of "canceled" and related terms to American English across the documentation and protobuf definitions. The changes are consistent and improve the specification's uniformity. The update to TASK_STATE_CANCELED in the .proto file is a breaking change, which is correctly indicated in the commit message. I have one minor suggestion to improve stylistic consistency in one of the documentation files.

@holtskinner holtskinner merged commit 4dd980f into a2aproject:main Jan 29, 2026
7 checks passed
darrelmiller pushed a commit that referenced this pull request Mar 12, 2026
🤖 I have created a release *beep* *boop*
---


## [1.0.0](v0.3.0...v1.0.0)
(2026-03-12)


### ⚠ BREAKING CHANGES

* **spec:** Combine `TaskPushNotificationConfig` and
`PushNotificationConfig`
([#1500](#1500))
* **spec:** remove duplicated ID from the create task push config
request ([#1487](#1487))
* **spec:** pluralize configs in `ListTaskPushNotificationConfigs`
([#1486](#1486))
* **spec:** Add LF prefix to the package.
([#1474](#1474))
* **spec:** Switch to non-complex IDs in requests
([#1389](#1389))
* **spec:** Standardize spelling of "canceled" to use American Spelling
throughout ([#1283](#1283))
* **spec:** Align enum format with ADR-001 ProtoJSON specification
([#1384](#1384))
* **spec:** Remove redundant `final` field from `TaskStatusUpdateEvent`
([#1308](#1308))
* **spec:** Move `extendedAgentCard` field to `AgentCapabilities`
([#1307](#1307))
* **spec:** Fixes for the last_updated_after field
([#1358](#1358))
* **spec:** modernize oauth 2.0 flows - remove implicit/password, add
device code / pkce
([#1303](#1303))
* **spec:** Make "message" field name consistent between protocol
bindings ([#1302](#1302))
* **spec:** Remove deprecated fields from a2a.proto for v1.0 release
([#1301](#1301))
* **spec:** Rename `supportsAuthenticatedExtendedCard` to
`supportsExtendedAgentCard`
([#1222](#1222))
* **spec:** Remove v1s from a2a url http bindings
* **spec:** Large refactor of specification to separate application
protocol definition from mapping to transports

### Features

* **spec:** Add `tasks/list` method with filtering and pagination to the
specification
([0a9f629](0a9f629))
* **spec:** modernize oauth 2.0 flows - remove implicit/password, add
device code / pkce
([#1303](#1303))
([525ff38](525ff38))
* **spec:** Natively Support Multi-tenancy on gRPC through an additional
scope field on the request.
([#1195](#1195))
([cfbce32](cfbce32)),
closes [#1148](#1148)
* **spec:** Provide ability for SDKs to be backwards compatible.
([#1401](#1401))
([227e249](227e249))
* **spec:** Remove v1s from a2a url http bindings
([1bd263f](1bd263f))


### Bug Fixes

* Add missing metadata field to Part message in gRPC specification
([#1019](#1019))
([b3b266d](b3b266d)),
closes [#1005](#1005)
* Add name field to FilePart protobuf message
([#983](#983))
([2b7cb6f](2b7cb6f)),
closes [#984](#984)
* Clarify blocking calls return on interrupted states
([#1403](#1403))
([0655ff3](0655ff3))
* **doc:** Makes JSON-RPC SendMessage response clearer
([#1241](#1241))
([5792804](5792804))
* **docs:** Clearer wording around context id.
([#1588](#1588))
([dec790a](dec790a))
* **grpc:** Fix inconsistent property name between gRPC and JSON-RPC in
Message object ([#1100](#1100))
([2a1f819](2a1f819))
* **grpc:** missing field in gRPC spec - state_transition_history
([#1138](#1138))
([a2de798](a2de798)),
closes [#1139](#1139)
* **grpc:** Update `CreateTaskPushNotificationConfig` endpoint to
`/v1/{parent=tasks/*/pushNotificationConfigs}`
([#979](#979))
([911f9b0](911f9b0))
* **proto:** Add icon_url to a2a.proto
([#986](#986))
([17e7f62](17e7f62))
* **proto:** Adds metadata field to A2A DataPart proto
([#1004](#1004))
([a8b45dc](a8b45dc))
* Remove unimplemented state_transition_history capability field
([#1396](#1396))
([c768a44](c768a44)),
closes [#1228](#1228)
* Restore CreateTaskPushNotificationConfig method naming
([#1402](#1402))
([d14f410](d14f410))
* Revert "chore(gRPC): Update a2a.proto to include metadata on
GetTaskRequest" ([#1000](#1000))
([e6b8c65](e6b8c65))
* Simplify Part message structure by flattening FilePart and DataPart
([#1411](#1411))
([bfae8f7](bfae8f7))
* **spec:** Add LF prefix to the package.
([#1474](#1474))
([a54e809](a54e809))
* **spec:** add metadata to `CancelTaskRequest`
([#1485](#1485))
([c441b91](c441b91)),
closes [#1484](#1484)
* **spec:** Added clarification on timestamps in HTTP query params
([#1425](#1425))
([6292104](6292104))
* **spec:** Added clarifying text around messages and artifacts
([#1424](#1424))
([b03d141](b03d141))
* **spec:** Adjust field number for `ListTasksRequest.tenant` to prevent
missing number ([#1470](#1470))
([cd16c52](cd16c52))
* **spec:** Clarify contextId behavior when message is sent with taskId
but without contextId
([#1309](#1309))
([a336a5a](a336a5a))
* **spec:** Clarify versioning strategy and client responsibilities in
protocol specification
([#1259](#1259))
([a4afeea](a4afeea))
* **spec:** Fix/1251 clarify authentication scheme
([#1256](#1256))
([3e6c7db](3e6c7db))
* **spec:** Fixes for the last_updated_after field
([#1358](#1358))
([0e204bf](0e204bf))
* **spec:** Make "message" field name consistent between protocol
bindings ([#1302](#1302))
([1e5f462](1e5f462)),
closes [#1230](#1230)
* **spec:** make `history_length` optional
([#1071](#1071))
([0572953](0572953))
* **spec:** pluralize configs in `ListTaskPushNotificationConfigs`
([#1486](#1486))
([cf735cb](cf735cb))
* **spec:** Remove config from binding.
([#1587](#1587))
([010b9cc](010b9cc))
* **spec:** Remove deprecated fields from a2a.proto for v1.0 release
([#1301](#1301))
([60f83c3](60f83c3)),
closes [#1227](#1227)
* **spec:** remove duplicated ID from the create task push config
request ([#1487](#1487))
([393898d](393898d))
* **spec:** Remove metadata field from ListTasksRequest
([#1235](#1235))
([b6ef9ee](b6ef9ee))
* **spec:** Remove reserved and fix tags ordering
([#1494](#1494))
([1997c9d](1997c9d))
* **spec:** Rename `supportsAuthenticatedExtendedCard` to
`supportsExtendedAgentCard`
([#1222](#1222))
([c196824](c196824)),
closes [#1215](#1215)
* **spec:** Standardize spelling of "canceled" to use American Spelling
throughout ([#1283](#1283))
([4dd980f](4dd980f))
* **spec:** Suggest Unique Identifier fields to be UUID
([#966](#966))
([00cf76e](00cf76e))
* **spec:** Switch to non-complex IDs in requests
([#1389](#1389))
([2596c1c](2596c1c)),
closes [#1390](#1390)
* **spec:** Update security schemes example
([#1364](#1364))
([f9a8f5b](f9a8f5b))
* Update the Java tutorials and descriptions
([#1181](#1181))
([202aa06](202aa06))


### Documentation

* **spec:** Align enum format with ADR-001 ProtoJSON specification
([#1384](#1384))
([810eaa1](810eaa1)),
closes [#1344](#1344)


### Code Refactoring

* **spec:** Combine `TaskPushNotificationConfig` and
`PushNotificationConfig`
([#1500](#1500))
([d1ed0da](d1ed0da))
* **spec:** Large refactor of specification to separate application
protocol definition from mapping to transports
([b078419](b078419))
* **spec:** Move `extendedAgentCard` field to `AgentCapabilities`
([#1307](#1307))
([40d6286](40d6286))
* **spec:** Remove redundant `final` field from `TaskStatusUpdateEvent`
([#1308](#1308))
([5b101cc](5b101cc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Amye Scavarda Perrin <amye@amye.org>
Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Proto has TASK_STATE_CANCELLED, but parts of the text still use 'canceled'

5 participants