Retire Flow Cross amendment by vvysokikh1 · Pull Request #5562 · XRPLF/rippled

vvysokikh1 · 2025-07-14T14:41:15Z

High Level Overview of Change

This PR addresses #5558

We are retiring FlowCross amendment which was long overdue for this. All code branches that have this amendment disabled are removed.

Context of Change

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
Performance (increase or change in throughput and/or latency)
Tests (you added tests for code that already exists, or your new feature included in this PR)
Documentation update
Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
Release

API Impact

Public API: New feature (new methods and/or new fields)
Public API: Breaking change (in general, breaking changes should only impact the next api_version)
libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
Peer protocol change (must be backward compatible or bump the peer protocol version)

src/test/app/Offer_test.cpp

src/xrpld/app/paths/detail/BookStep.cpp

ximinez · 2025-07-14T18:44:32Z

Please mention in the commit message and/or PR description that this resolves #5558. I think either will close the Issue when this PR is merged.

vvysokikh1 · 2025-07-15T10:25:59Z

Please mention in the commit message and/or PR description that this resolves #5558. I think either will close the Issue when this PR is merged.

I've added an empty commit with "Closes #5558", it will close the Issue once merged into develop

codecov · 2025-07-15T13:04:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.4%. Comparing base (452263e) to head (bca0764).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5562     +/-   ##
=========================================
- Coverage     79.0%   78.4%   -0.6%     
=========================================
  Files          816     816             
  Lines        71752   71709     -43     
  Branches      8320    8595    +275     
=========================================
- Hits         56670   56222    -448     
- Misses       15082   15487    +405

Files with missing lines	Coverage Δ
src/xrpld/app/paths/detail/BookStep.cpp	`93.0% <100.0%> (-<0.1%)`	⬇️
src/xrpld/app/tx/detail/CreateOffer.cpp	`67.6% <100.0%> (-24.3%)`	⬇️
src/xrpld/app/tx/detail/CreateOffer.h	`100.0% <ø> (ø)`

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Bronek

Nice, thank you for doing it !

* XRPLF/develop: test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562)

…refactoring-1 * upstream/develop: (56 commits) Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) chore: Fix compilation error with clang-20 and cleanup (#5543) test: Remove circular jtx.h dependencies (#5544) Decouple CredentialHelpers from xrpld/app/tx (#5487) fix: crash when trace-logging in tests (#5529) test: switch some unit tests to doctest (#5383) ...

…actoring-2 * ximinez/lending-refactoring-1: (57 commits) Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) chore: Fix compilation error with clang-20 and cleanup (#5543) test: Remove circular jtx.h dependencies (#5544) Decouple CredentialHelpers from xrpld/app/tx (#5487) fix: crash when trace-logging in tests (#5529) ...

…actoring-3 * ximinez/lending-refactoring-2: (57 commits) Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) chore: Fix compilation error with clang-20 and cleanup (#5543) test: Remove circular jtx.h dependencies (#5544) Decouple CredentialHelpers from xrpld/app/tx (#5487) fix: crash when trace-logging in tests (#5529) ...

…actoring-4 * ximinez/lending-refactoring-3: (61 commits) fixup! Rename Transactor preflight functions Rename Transactor preflight functions fixup! Make preflight1 and preflight2 private static Transactor functions Make preflight1 and preflight2 private static Transactor functions Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) ...

…actoring-4 * ximinez/lending-refactoring-3: (61 commits) fixup! Rename Transactor preflight functions Rename Transactor preflight functions fixup! Make preflight1 and preflight2 private static Transactor functions Make preflight1 and preflight2 private static Transactor functions Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) ... Co-authored-by: Bronek Kozicki <brok@incorrekt.com>

After the `FlowCross` amendment was retired (#5562), there was still some unused code left. This change removes the remaining remnants.

Retire Flow Cross amendment

393b1e6

vvysokikh1 force-pushed the vvysokikh1/retire_flow_cross branch from 02afc7b to 393b1e6 Compare July 14, 2025 14:50

Removed takerCross

ec47e44

Bronek reviewed Jul 14, 2025

View reviewed changes

src/test/app/Offer_test.cpp Outdated Show resolved Hide resolved

Removed takerTests

6e7c6d3

Bronek reviewed Jul 14, 2025

View reviewed changes

src/xrpld/app/paths/detail/BookStep.cpp Outdated Show resolved Hide resolved

Comment fixes

c77dd92

vvysokikh1 marked this pull request as ready for review July 14, 2025 15:55

vvysokikh1 requested a review from a team July 14, 2025 15:55

Bronek self-requested a review July 14, 2025 15:55

vvysokikh1 added 2 commits July 15, 2025 11:18

fixed tests

b91c894

Closes #5558

4ee1fbe

vvysokikh1 and others added 2 commits July 15, 2025 15:44

cleaned up

b6fc7dc

Merge branch 'develop' into vvysokikh1/retire_flow_cross

bca0764

Bronek approved these changes Jul 16, 2025

View reviewed changes

vvysokikh1 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Jul 16, 2025

bthomee approved these changes Jul 16, 2025

View reviewed changes

bthomee merged commit c9135a6 into develop Jul 16, 2025
3 checks passed

bthomee deleted the vvysokikh1/retire_flow_cross branch July 16, 2025 10:53

Bronek mentioned this pull request Jul 16, 2025

FlowCross is overdue for retirement #5558

Closed

ximinez added a commit that referenced this pull request Jul 16, 2025

Merge remote-tracking branch 'XRPLF/develop' into ximinez/lending-XLS-66

89dbb48

* XRPLF/develop: test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562)

vvysokikh1 mentioned this pull request Jul 17, 2025

Removed unused code after flow cross retirement #5575

Merged

13 tasks

bthomee pushed a commit that referenced this pull request Jul 23, 2025

chore: Remove unused code after flow cross retirement (#5575)

433eeab

After the `FlowCross` amendment was retired (#5562), there was still some unused code left. This change removes the remaining remnants.

This was referenced Aug 27, 2025

Release 2.6.0 #5741

Merged

Release 2.6.0 #5742

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Retire Flow Cross amendment#5562

Retire Flow Cross amendment#5562
bthomee merged 8 commits intodevelopfrom
vvysokikh1/retire_flow_cross

vvysokikh1 commented Jul 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

ximinez commented Jul 14, 2025

Uh oh!

vvysokikh1 commented Jul 15, 2025

Uh oh!

codecov bot commented Jul 15, 2025 •

edited

Loading

Uh oh!

Bronek left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

vvysokikh1 commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

High Level Overview of Change

Context of Change

Type of Change

API Impact

Uh oh!

Uh oh!

Uh oh!

ximinez commented Jul 14, 2025

Uh oh!

vvysokikh1 commented Jul 15, 2025

Uh oh!

codecov bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Bronek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vvysokikh1 commented Jul 14, 2025 •

edited

Loading

codecov bot commented Jul 15, 2025 •

edited

Loading