Run unit tests regardless of 'Supported' amendment status by vvysokikh1 · Pull Request #5537 · XRPLF/rippled

vvysokikh1 · 2025-07-07T11:03:05Z

High Level Overview of Change

Enable running tests regardless of 'Supported' amendment status.

For the review purpose, the functional change is in the first commit. Second commit only renames the function to better reflect its functionality

Context of Change

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
Performance (increase or change in throughput and/or latency)
Tests (you added tests for code that already exists, or your new feature included in this PR)
Documentation update
Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
Release

API Impact

Public API: New feature (new methods and/or new fields)
Public API: Breaking change (in general, breaking changes should only impact the next api_version)
libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
Peer protocol change (must be backward compatible or bump the peer protocol version)

src/test/jtx/Env.h

codecov · 2025-07-08T12:05:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.4%. Comparing base (c9135a6) to head (53bf7a7).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #5537   +/-   ##
=======================================
  Coverage     78.4%   78.4%           
=======================================
  Files          816     816           
  Lines        71709   71709           
  Branches      8598    8595    -3     
=======================================
+ Hits         56215   56220    +5     
+ Misses       15494   15489    -5

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ximinez

Looks good, but I have a question.

Is there a way that I, as a developer, can exclude a given amendment from all existing tests? Say for example that I'm in the middle of some development task, and I create amendment X for it, and I make some non-amendment changes that I want to ensure don't break anything. Normally, I would Supported::no, run the tests, then maybe set it back to Supported::yes, and run them again. This can be done with individual tests trivially, but can it be done globally?

vvysokikh1 · 2025-07-10T22:55:49Z

Looks good, but I have a question.

Is there a way that I, as a developer, can exclude a given amendment from all existing tests? Say for example that I'm in the middle of some development task, and I create amendment X for it, and I make some non-amendment changes that I want to ensure don't break anything. Normally, I would Supported::no, run the tests, then maybe set it back to Supported::yes, and run them again. This can be done with individual tests trivially, but can it be done globally?

I'm not aware of this capability. If you see this as a blocker, I can think of the solution (maybe some compile time flags to be able to make such a specific build for testing?)

…_of_supported_status

ximinez · 2025-07-16T15:34:55Z

Is there a way that I, as a developer, can exclude a given amendment from all existing tests? [...]

I'm not aware of this capability. If you see this as a blocker, I can think of the solution (maybe some compile time flags to be able to make such a specific build for testing?)

I don't think it's a blocker, particularly since I thought of a way to do it.

Simply remove the amendment from the result in testable_amendments. e.g.

inline FeatureBitset
testable_amendments()
{
    static FeatureBitset const ids = [] {
[...]
    }();
    // TODO: Remove the modification before merging
    return ids - featureUnderConstruction;
}

Just make sure it's not merged that way.

vvysokikh1 · 2025-07-16T15:40:18Z

Is there a way that I, as a developer, can exclude a given amendment from all existing tests? [...]

I'm not aware of this capability. If you see this as a blocker, I can think of the solution (maybe some compile time flags to be able to make such a specific build for testing?)

I don't think it's a blocker, particularly since I thought of a way to do it.

Simply remove the amendment from the result in testable_amendments. e.g.
inline FeatureBitset
testable_amendments()
{
    static FeatureBitset const ids = [] {
[...]
    }();
    // TODO: Remove the modification before merging
    return ids - featureUnderConstruction;
}
Just make sure it's not merged that way.

Such thing should be quite visible during review, so I don't think this will be a problem

* XRPLF/develop: test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562)

…refactoring-1 * upstream/develop: (56 commits) Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) chore: Fix compilation error with clang-20 and cleanup (#5543) test: Remove circular jtx.h dependencies (#5544) Decouple CredentialHelpers from xrpld/app/tx (#5487) fix: crash when trace-logging in tests (#5529) test: switch some unit tests to doctest (#5383) ...

…actoring-2 * ximinez/lending-refactoring-1: (57 commits) Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) chore: Fix compilation error with clang-20 and cleanup (#5543) test: Remove circular jtx.h dependencies (#5544) Decouple CredentialHelpers from xrpld/app/tx (#5487) fix: crash when trace-logging in tests (#5529) ...

…actoring-3 * ximinez/lending-refactoring-2: (57 commits) Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) chore: Fix compilation error with clang-20 and cleanup (#5543) test: Remove circular jtx.h dependencies (#5544) Decouple CredentialHelpers from xrpld/app/tx (#5487) fix: crash when trace-logging in tests (#5529) ...

…actoring-4 * ximinez/lending-refactoring-3: (61 commits) fixup! Rename Transactor preflight functions Rename Transactor preflight functions fixup! Make preflight1 and preflight2 private static Transactor functions Make preflight1 and preflight2 private static Transactor functions Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) ...

…actoring-4 * ximinez/lending-refactoring-3: (61 commits) fixup! Rename Transactor preflight functions Rename Transactor preflight functions fixup! Make preflight1 and preflight2 private static Transactor functions Make preflight1 and preflight2 private static Transactor functions Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) ... Co-authored-by: Bronek Kozicki <brok@incorrekt.com>

run tests regardless of 'Supported' amendment status

3d6070f

ximinez reviewed Jul 7, 2025

View reviewed changes

src/test/jtx/Env.h Show resolved Hide resolved

vvysokikh1 force-pushed the vvysokikh1/test_regardless_of_supported_status branch from c87dc91 to ff99038 Compare July 8, 2025 09:41

rename function

0d7b2d2

vvysokikh1 force-pushed the vvysokikh1/test_regardless_of_supported_status branch from ff99038 to 0d7b2d2 Compare July 8, 2025 09:43

Bronek mentioned this pull request Jul 8, 2025

Fix failing AMM Clawback test #5539

Merged

Fix failing AMM Clawback test

79b2ae9

vvysokikh1 requested a review from ximinez July 8, 2025 13:10

ximinez approved these changes Jul 10, 2025

View reviewed changes

Merge remote-tracking branch 'origin' into vvysokikh1/test_regardless…

4be5483

…_of_supported_status

vvysokikh1 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Jul 16, 2025

vvysokikh1 added 2 commits July 16, 2025 12:03

Merge remote-tracking branch 'origin' into vvysokikh1/test_regardless…

49ba7ac

…_of_supported_status

fixed comments

53bf7a7

bthomee approved these changes Jul 16, 2025

View reviewed changes

bthomee enabled auto-merge (squash) July 16, 2025 11:07

bthomee merged commit 8bfaa7f into develop Jul 16, 2025
3 checks passed

bthomee deleted the vvysokikh1/test_regardless_of_supported_status branch July 16, 2025 11:47

ximinez added a commit that referenced this pull request Jul 16, 2025

Merge remote-tracking branch 'XRPLF/develop' into ximinez/lending-XLS-66

89dbb48

* XRPLF/develop: test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562)

This was referenced Aug 27, 2025

Release 2.6.0 #5741

Merged

Release 2.6.0 #5742

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run unit tests regardless of 'Supported' amendment status#5537

Run unit tests regardless of 'Supported' amendment status#5537
bthomee merged 6 commits intodevelopfrom
vvysokikh1/test_regardless_of_supported_status

vvysokikh1 commented Jul 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

codecov bot commented Jul 8, 2025 •

edited

Loading

Uh oh!

ximinez left a comment

Uh oh!

vvysokikh1 commented Jul 10, 2025

Uh oh!

Uh oh!

ximinez commented Jul 16, 2025

Uh oh!

vvysokikh1 commented Jul 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

vvysokikh1 commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

High Level Overview of Change

Context of Change

Type of Change

API Impact

Uh oh!

Uh oh!

codecov bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ximinez left a comment

Choose a reason for hiding this comment

Uh oh!

vvysokikh1 commented Jul 10, 2025

Uh oh!

Uh oh!

ximinez commented Jul 16, 2025

Uh oh!

vvysokikh1 commented Jul 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vvysokikh1 commented Jul 7, 2025 •

edited

Loading

codecov bot commented Jul 8, 2025 •

edited

Loading