chore: Removed unused headers by vvysokikh1 · Pull Request #5526 · XRPLF/rippled

vvysokikh1 · 2025-07-02T14:45:14Z

High Level Overview of Change

This is not a comprehensive cleanup. Just some that got my attention.

Context of Change

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
Performance (increase or change in throughput and/or latency)
Tests (you added tests for code that already exists, or your new feature included in this PR)
Documentation update
Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
Release

API Impact

Public API: New feature (new methods and/or new fields)
Public API: Breaking change (in general, breaking changes should only impact the next api_version)
libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
Peer protocol change (must be backward compatible or bump the peer protocol version)

codecov · 2025-07-02T15:12:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.1%. Comparing base (8e94ea3) to head (5bfed37).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5526     +/-   ##
=========================================
- Coverage     79.1%   79.1%   -0.0%     
=========================================
  Files          816     816             
  Lines        71625   71624      -1     
  Branches      8239    8259     +20     
=========================================
- Hits         56639   56620     -19     
- Misses       14986   15004     +18

Files with missing lines	Coverage Δ
include/xrpl/basics/Buffer.h	`100.0% <ø> (ø)`
include/xrpl/basics/StringUtilities.h	`100.0% <ø> (ø)`
include/xrpl/basics/algorithm.h	`100.0% <ø> (ø)`
include/xrpl/basics/hardened_hash.h	`100.0% <ø> (ø)`
include/xrpl/basics/tagged_integer.h	`100.0% <ø> (ø)`
include/xrpl/beast/clock/abstract_clock.h	`100.0% <ø> (ø)`
include/xrpl/beast/clock/manual_clock.h	`100.0% <ø> (ø)`
...east/container/detail/aged_associative_container.h	`100.0% <ø> (ø)`
...pl/beast/container/detail/aged_ordered_container.h	`97.4% <ø> (ø)`
include/xrpl/beast/core/LexicalCast.h	`92.7% <ø> (ø)`
... and 31 more

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…eaders

bthomee

What tool did you use to determine these unused headers? I had used clang-tidy in the past and it not only suggested removing many headers but also adding many headers to "Include What You Use" per file.

I have an open issue to add clang-tidy to both CI and pre-commit, so I'd like to make sure that, once that gets enabled, all the headers you're removing now will need to be added back.

include/xrpl/beast/hash/hash_append.h

include/xrpl/basics/Buffer.h

Bronek · 2025-07-10T16:53:50Z

@vvysokikh1 I just tested that this branch builds successfully with clang-20

* XRPLF/develop: chore: Remove unused headers (#5526)

* XRPLF/develop: fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526)

…refactoring-1 * upstream/develop: (56 commits) Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) chore: Fix compilation error with clang-20 and cleanup (#5543) test: Remove circular jtx.h dependencies (#5544) Decouple CredentialHelpers from xrpld/app/tx (#5487) fix: crash when trace-logging in tests (#5529) test: switch some unit tests to doctest (#5383) ...

…actoring-2 * ximinez/lending-refactoring-1: (57 commits) Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) chore: Fix compilation error with clang-20 and cleanup (#5543) test: Remove circular jtx.h dependencies (#5544) Decouple CredentialHelpers from xrpld/app/tx (#5487) fix: crash when trace-logging in tests (#5529) ...

…actoring-3 * ximinez/lending-refactoring-2: (57 commits) Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) chore: Fix compilation error with clang-20 and cleanup (#5543) test: Remove circular jtx.h dependencies (#5544) Decouple CredentialHelpers from xrpld/app/tx (#5487) fix: crash when trace-logging in tests (#5529) ...

…actoring-4 * ximinez/lending-refactoring-3: (61 commits) fixup! Rename Transactor preflight functions Rename Transactor preflight functions fixup! Make preflight1 and preflight2 private static Transactor functions Make preflight1 and preflight2 private static Transactor functions Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) ...

…actoring-4 * ximinez/lending-refactoring-3: (61 commits) fixup! Rename Transactor preflight functions Rename Transactor preflight functions fixup! Make preflight1 and preflight2 private static Transactor functions Make preflight1 and preflight2 private static Transactor functions Fix formatting Remove `include(default)` from libxrpl profile (#5587) refactor: Change boost::shared_mutex to std::shared_mutex (#5576) Fix macos runner (#5585) Remove the type filter from "ledger" RPC command (#4934) refactor: Update date, libarchive, nudb, openssl, sqlite3, xxhash packages (#5567) test: Run unit tests regardless of 'Supported' amendment status (#5537) Retire Flow Cross amendment (#5562) chore: Update CI to use Conan 2 (#5556) fixAMMClawbackRounding: adjust last holder's LPToken balance (#5513) chore: Add gcc-12 workaround (#5554) Add MPT related txns into issuer's account history (#5530) chore: Remove unused headers (#5526) fix: add allowTrustLineLocking flag for account_info (#5525) Downgrade required CMake version for Antithesis SDK (#5548) fix: Link with boost libraries explicitly (#5546) ... Co-authored-by: Bronek Kozicki <brok@incorrekt.com>

removed unused headers

6ee6de1

vvysokikh1 requested a review from a team July 2, 2025 14:45

vvysokikh1 added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Jul 2, 2025

vvysokikh1 changed the title ~~choreIRemoved unused headers~~ chore: Removed unused headers Jul 2, 2025

fix

fb40eba

Merge remote-tracking branch 'origin' into vvysokikh1/remove_unused_h…

da6155a

…eaders

bthomee approved these changes Jul 10, 2025

View reviewed changes

include/xrpl/beast/hash/hash_append.h Show resolved Hide resolved

Bronek reviewed Jul 10, 2025

View reviewed changes

include/xrpl/basics/Buffer.h Show resolved Hide resolved

Merge branch 'develop' into vvysokikh1/remove_unused_headers

5bfed37

bthomee enabled auto-merge (squash) July 10, 2025 17:26

bthomee merged commit 6534757 into develop Jul 10, 2025
3 checks passed

bthomee deleted the vvysokikh1/remove_unused_headers branch July 10, 2025 18:15

ximinez added a commit that referenced this pull request Jul 11, 2025

Merge remote-tracking branch 'XRPLF/develop' into ximinez/lending-XLS-66

7af34cb

* XRPLF/develop: chore: Remove unused headers (#5526)

This was referenced Aug 27, 2025

Release 2.6.0 #5741

Merged

Release 2.6.0 #5742

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Removed unused headers#5526

chore: Removed unused headers#5526
bthomee merged 4 commits intodevelopfrom
vvysokikh1/remove_unused_headers

vvysokikh1 commented Jul 2, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jul 2, 2025 •

edited

Loading

Uh oh!

bthomee left a comment

Uh oh!

Uh oh!

Uh oh!

Bronek commented Jul 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

vvysokikh1 commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

High Level Overview of Change

Context of Change

Type of Change

API Impact

Uh oh!

codecov bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bthomee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Bronek commented Jul 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vvysokikh1 commented Jul 2, 2025 •

edited

Loading

codecov bot commented Jul 2, 2025 •

edited

Loading