Skip to content

0.13.0 #146

Merged
UnHumbleBen merged 27 commits intomasterfrom
dev
Nov 22, 2020
Merged

0.13.0 #146
UnHumbleBen merged 27 commits intomasterfrom
dev

Conversation

@UnHumbleBen
Copy link
Copy Markdown
Collaborator

No description provided.

UnHumbleBen and others added 22 commits September 16, 2020 17:29
* Also renamed Python package workflow to Run Unit Tests for clarity
…checks-for-docs-and-pypi

Fixes #125; CI checks for docs and PyPI packaging
…cally population field Modification.id with Modification.idt_text if latter is specified and former is not
…t_idt to break with cadnano's naming convention and ensure strand names are unique
This fixes issue where PR from external forks would not have
CI checks, as in [this PR](#142).

This commit fixes this issue, as shown in this
[sample PR](https://github.com/UnHumbleBen/scadnano-python-package-1/pull/5).
You can see that CI tests run now.
Swapped x and z values of helix groups and helix positions,
with the exception of 1_staple_1_helix_origami_position_nondefault.sc
where the exact position didn't matter
Fixes #144; swap position x z coordinate interpretation
@dave-doty
Copy link
Copy Markdown
Member

dave-doty commented Nov 9, 2020

Update: Nevermind, I wrote what's below not realizing that this is the Python package, not the web interface. But I'd still like to wait to update both until we've stress-tested the web interface a bit on the dev branch.

I say let's wait on this merge for a bit. I'd like to ask a few people to use the dev branch a bit to spot if they run into any problems.

I'm also quite confused (and concerned), because I made several commits to the dev branch in the past week, related to issues UC-Davis-molecular-computing/scadnano#501, UC-Davis-molecular-computing/scadnano#502, UC-Davis-molecular-computing/scadnano#504, UC-Davis-molecular-computing/scadnano#505.

but I don't see those commits listed here:

https://github.com/UC-Davis-molecular-computing/scadnano-python-package/commits/dev

or here:

https://github.com/UC-Davis-molecular-computing/scadnano-python-package/pull/146/commits

You can see each commit linked in the issue when it was closed, e.g., commit UC-Davis-molecular-computing/scadnano@8112c43 closed issue UC-Davis-molecular-computing/scadnano#501.

@UnHumbleBen UnHumbleBen merged commit aab5614 into master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants