Skip to content

Adds PR to CI workflow#143

Merged
UnHumbleBen merged 2 commits intodevfrom
dev-add-pr-to-ci-workflow
Oct 3, 2020
Merged

Adds PR to CI workflow#143
UnHumbleBen merged 2 commits intodevfrom
dev-add-pr-to-ci-workflow

Conversation

@UnHumbleBen
Copy link
Copy Markdown
Collaborator

@UnHumbleBen UnHumbleBen commented Oct 2, 2020

This fixes issue where PR from external forks would not have
CI checks, as in this PR.

This commit fixes this issue, as shown in this
sample PR.
You can see that CI tests run now.

@UnHumbleBen
Adds PR to CI workflow
ecf5ced 
This fixes issue where PR from external forks would not have
CI checks, as in [this PR](#142).

This commit fixes this issue, as shown in this
[sample PR](https://github.com/UnHumbleBen/scadnano-python-package-1/pull/5).
You can see that CI tests run now.
@UnHumbleBen UnHumbleBen requested a review from dave-doty as a code owner October 2, 2020 18:22
dave-doty
dave-doty requested changes Oct 2, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dave-doty dave-doty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to do it where it does not run two redundant checks when we do PRs? The one you just created, for instance, has two versions of each check:

image

Probably not a huge deal, but I'd like to do this on the Dart repo as well, and that one has much longer-running CI, and I recall an email recently indicating that they are limiting the number of CI minutes we get per month for free.

@UnHumbleBen
Copy link
Copy Markdown
Collaborator Author

UnHumbleBen commented Oct 2, 2020

What do you think of removing the push event? I.e. CI will only run with when PR is made and updated (i.e. commits made on PR).

@dave-doty
Copy link
Copy Markdown
Member

dave-doty commented Oct 2, 2020

What do you think of removing the push event? I.e. CI will only run with when PR is made and updated (i.e. commits made on PR).

Sure, if that achieves the desired behavior.

@UnHumbleBen
Copy link
Copy Markdown
Collaborator Author

UnHumbleBen commented Oct 2, 2020

This should give us the desired behavior. Since we can't push directly to dev anymore, any changes we made to dev will be done via PRs, so every change to dev will have CI workflow run on it. When dev to master, CI checks will be done here as well.

@UnHumbleBen UnHumbleBen requested a review from dave-doty October 2, 2020 19:08
@UnHumbleBen UnHumbleBen merged commit 22a5b19 into dev Oct 3, 2020
@dave-doty dave-doty deleted the dev-add-pr-to-ci-workflow branch August 9, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dave-doty dave-doty dave-doty approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@UnHumbleBen @dave-doty