Parse IDTFields when loading scadnano json.#142
Closed
cgevans wants to merge 1 commit intoUC-Davis-molecular-computing:devfrom
Closed
Parse IDTFields when loading scadnano json.#142cgevans wants to merge 1 commit intoUC-Davis-molecular-computing:devfrom
cgevans wants to merge 1 commit intoUC-Davis-molecular-computing:devfrom
Conversation
Member
|
Thanks! I implemented this myself just now, a bit differently, so closing this PR. |
UnHumbleBen
added a commit
that referenced
this pull request
Oct 2, 2020
This fixes issue where PR from external forks would not have CI checks, as in [this PR](#142). This commit fixes this issue, as shown in this [sample PR](https://github.com/UnHumbleBen/scadnano-python-package-1/pull/5). You can see that CI tests run now.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, on loading a scadnano json file, idt is set to a dict for Strand, rather than an IDTFields. This parses the dict and sets idt accordingly.