Fixes #144; swap position x z coordinate interpretation#145
Conversation
dave-doty
left a comment
There was a problem hiding this comment.
I'm a bit confused. This looks like very little changed. Just one file, and essentially only comments in that file changed.
|
I think there isn't much to change in the python package? I thought most of
the change would be in the scadnano web app.
…On Sun, Nov 1, 2020 at 1:26 PM David Doty ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I'm a bit confused. This looks like very little changed. Just one file,
and essentially only comments in that file changed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#145 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHOOY75N4I2PMW2CRLSKGSTSNXHAFANCNFSM4TGW26LA>
.
|
dave-doty
left a comment
There was a problem hiding this comment.
Oops, didn't notice which repo it is.
Swapped x and z values of helix groups and helix positions, with the exception of 1_staple_1_helix_origami_position_nondefault.sc where the exact position didn't matter
|
@dave-doty I changed the scripts associated with the Another thing that comes to mind is does the cadnano import need to be rewritten? I imagine it doesn't because cadnano doesn't have gridless option, but just want to make sure. Once I add the changes to |
No, proposal isn't used in the dropdown menu of examples.
Try importing a cadnano design and see if it works. |
|
I am actually confused about the purpose of the |
Pure laziness. This way I can run a script that copies all examples from the Python repo to here, without thinking about which ones are used in the dropdown menu. |
Do not merge until UC-Davis-molecular-computing/scadnano#488 is closed