Fixes #125; CI checks for docs and PyPI packaging#141
Merged
Conversation
Collaborator
UnHumbleBen
commented
Sep 18, 2020
- Also renamed Python package workflow to Run Unit Tests for clarity
* Also renamed Python package workflow to Run Unit Tests for clarity
dave-doty
reviewed
Sep 18, 2020
Member
dave-doty
left a comment
There was a problem hiding this comment.
Can I ask how these work, in particular what will cause it to alert us with a red warning that a check failed? I don't see an explicit check; is it relying on return codes from the executed commands?
Collaborator
Author
|
GitHub actions use the exit codes of the tasks. |
dave-doty
approved these changes
Sep 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.