Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11607 +/- ##
=========================================
Coverage 22.13% 22.13%
Complexity 8928 8928
=========================================
Files 247 247
Lines 32170 32170
Branches 79 79
=========================================
Hits 7120 7120
Misses 24974 24974
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Noticed that the layout is a little bit off for phones / smaller screen devices, will push a fix soon |
Contributor
|
Hey Hinyan, I've been looking into this PR and it seems fine to me even on smaller screen sizes. Could you elaborate on what is causing the layout to appear "a bit off" on smaller screens? |
Filter no longer go under the thread post div on smaller screen sizes.
Contributor
Author
|
Forgot about this PR, sorry. The layout was off when I used the "toggle device toolbar" button in chrome dev tools (near the top left). If I remember correctly the right part of the bar would wrap to a new line on smaller screens when it's not supposed to. I don't have a screenshot unfortunately, and I can't get the VM working right now, so if you would like to verify or fix it that would be great. |
Made the buttons wrap a little better by only applying toolbar-right to "more". Likely not the best fit but it is a little better now as the buttos don't wrap as one unit.
williamschen23
approved these changes
May 23, 2025
Contributor
williamschen23
left a comment
There was a problem hiding this comment.
diff is very ugly but refactor works as intended.
bmcutler
pushed a commit
that referenced
this pull request
Sep 4, 2025
### Why is this Change Important & Necessary? <!-- Include any GitHub issue that is fixed/closed using "Fixes #<number>" or "Closes #<number>" syntax. Alternately write "Partially addresses #<number>" or "Related to #<number>" as appropriate. --> Fixes #12017 bug introduced in #11607 ### What is the New Behavior? <!-- Include before & after screenshots/videos if the user interface has changed. --> Forum search is fixed and a basic test is added to detect & prevent future breakages. ### What steps should a reviewer take to reproduce or test the bug or new feature? Attempt to search on Main -> see no results, undefined array key error. Attempt to search on this branch -> see results. ### Automated Testing & Documentation <!-- Is this feature sufficiently tested by unit tests and end-to-end tests? If this PR does not add/update the necessary automated tests, write a new GitHub issue and link it below. Is this feature sufficiently documented on submitty.org? Link related PRs or new GitHub issue to update documentation. --> Adds a basic cypress test for forum searching. ### Other information <!-- Is this a breaking change? Does this PR include migrations to update existing installations? Are there security concerns with this PR? --> --------- Co-authored-by: Alex Lavallee <alex@lavallee.one> Co-authored-by: williamschen23 <chenwill2005@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
What is the current behavior?
The old forum bar layout overlaps buttons when the window size shrinks.
What is the new behavior?
Rewrote the forum bar to use native flexbox instead of Bootstrap's grid system. Buttons don't overlap now.
Fixes #11592
Other information?
Tested by increasing and decreasing window size and adding filters on the main forums page
Tested on Chrome