Skip to content

[Bugfix:Forum] Fix and test search#12057

Merged
bmcutler merged 5 commits intomainfrom
forum-search-hotfix
Sep 4, 2025
Merged

[Bugfix:Forum] Fix and test search#12057
bmcutler merged 5 commits intomainfrom
forum-search-hotfix

Conversation

@DarthNyan
Copy link
Contributor

@DarthNyan DarthNyan commented Sep 2, 2025

Why is this Change Important & Necessary?

Fixes #12017
bug introduced in #11607

What is the New Behavior?

Forum search is fixed and a basic test is added to detect & prevent future breakages.

What steps should a reviewer take to reproduce or test the bug or new feature?

Attempt to search on Main -> see no results, undefined array key error.
Attempt to search on this branch -> see results.

Automated Testing & Documentation

Adds a basic cypress test for forum searching.

Other information

@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 21.70%. Comparing base (50018f0) to head (a26261e).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12057   +/-   ##
=========================================
  Coverage     21.70%   21.70%           
  Complexity     9582     9582           
=========================================
  Files           268      268           
  Lines         36560    36560           
  Branches        475      475           
=========================================
  Hits           7936     7936           
  Misses        28153    28153           
  Partials        471      471           
Flag Coverage Δ
autograder 21.31% <ø> (ø)
js 2.07% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.72% <0.00%> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DarthNyan DarthNyan moved this from Seeking Reviewer to Work in Progress in Submitty Development Sep 2, 2025
@automateprojectmangement automateprojectmangement bot moved this from Work in Progress to In Review in Submitty Development Sep 4, 2025
Copy link
Contributor

@williamschen23 williamschen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took some liberties and fixed some slight issues with cypress test. The functionality and cypress test now looks good. I also investigated the issue and found where it stemmed from, which is linked in the PR description

@github-project-automation github-project-automation bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Sep 4, 2025
@bmcutler bmcutler merged commit 95c7818 into main Sep 4, 2025
47 of 48 checks passed
@bmcutler bmcutler deleted the forum-search-hotfix branch September 4, 2025 16:20
@github-project-automation github-project-automation bot moved this from Awaiting Maintainer Review to Done in Submitty Development Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

discussion forum search is broken

4 participants