🦙 MegaLinter status: ✅ SUCCESS

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

Do we really want to catch every error twice? We already have the logic in the Table methods so the logic stays the same. If we want to change the logic of one of the errors we would have to do this in both the Table and the TaggedTable. I would prefer to only write additional errors in TaggedTable if they only occur in the TaggedTable methods or if they differ from the Table error logic/messages

Do we really want to catch every error twice? We already have the logic in the Table methods so the logic stays the same. If we want to change the logic of one of the errors we would have to do this in both the Table and the TaggedTable. I would prefer to only write additional errors in TaggedTable if they only occur in the TaggedTable methods or if they differ from the Table error logic/messages

That makes sense, it's not ideal. I'll revise my changes to include additional error handling where necessary.

Codecov Report

Merging #450 (963a1ce) into main (6a097a4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #450   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         2715      2714    -1     
=========================================
- Hits          2715      2714    -1     

@jxnior01 I removed additional errors that are being raised by the methods from the Table class

@jxnior01 I removed additional errors that are being raised by the methods from the Table class

Thanks. That was helpful.

Looks good to me, although I've spotted a few cases where we don't make use of the new "suggest columns" feature when raising an UnknownColumnNameError.
Not sure what our criterion is about when to make use of that, though.

Can merge if you like.

🎉 This PR is included in version 0.15.0 🎉

The release is available on:

• v0.15.0
• GitHub release

Your semantic-release bot 📦🚀