feat: add gaussian noise to image by patrikguempel · Pull Request #430 · Safe-DS/Library

patrikguempel · 2023-07-07T07:30:02Z

Closes #381

Summary of Changes

Images can now be modified with "gaussian noise".

added gaussian noise

…-gaussian-noise

github-actions · 2023-07-07T07:34:06Z

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	black	2	0	0	1.05s
✅ PYTHON	mypy	2		0	2.91s
✅ PYTHON	ruff	2	0	0	0.1s
✅ REPOSITORY	git_diff	yes		no	0.07s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

…-gaussian-noise

…-add-gaussian-noise

…-add-gaussian-noise # Conflicts: # tests/safeds/data/image/containers/test_image.py

…-add-gaussian-noise

src/safeds/data/image/containers/_image.py

…-add-gaussian-noise

codecov · 2023-07-07T13:47:50Z

Codecov Report

Merging #430 (8006b0d) into main (d71303d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #430   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         2665      2676   +11     
=========================================
+ Hits          2665      2676   +11

Impacted Files	Coverage Δ
src/safeds/data/image/containers/_image.py	`100.00% <100.00%> (ø)`

zzril · 2023-07-12T19:52:41Z

Need to add the new method to the image tutorial also.

Or do we generally create new issues for that? @lars-reimann

lars-reimann · 2023-07-12T19:58:45Z

Need to add the new method to the image tutorial also.

Or do we generally create new issues for that? @lars-reimann

No, that should be added as part of this PR now that #419 is merged.

lars-reimann · 2023-07-12T20:27:27Z

It's now added to the "Image Processing" tutorial.

zzril · 2023-07-12T20:35:01Z

Tests fail locally for me (top_level_collect).

lars-reimann · 2023-07-12T20:35:25Z

Run poetry install.

zzril · 2023-07-12T20:37:34Z

Run poetry install.

Ofc, thanks.

zzril

LGTM.

(Small remark about the tests: I think it would generally make sense to always include the edge cases (like giving a standard_deviation of 0) in the test cases.
But we're not doing that consistently anyway, so I'll still accept. Might be sthg for a new issue.)

lars-reimann · 2023-07-12T21:10:46Z

Thanks, I've added that edge case too.

zzril

## [0.15.0](v0.14.0...v0.15.0) (2023-07-13) ### Features * Add copy method for tables ([#405](#405)) ([72e87f0](72e87f0)), closes [#275](#275) * add gaussian noise to image ([#430](#430)) ([925a505](925a505)), closes [#381](#381) * add schema conversions when adding new rows to a table and schema conversion when creating a new table ([#432](#432)) ([6e9ff69](6e9ff69)), closes [#404](#404) [#322](#322) [#127](#127) [#322](#322) [#127](#127) * add test for empty tables for the method `Table.sort_rows` ([#431](#431)) ([f94b768](f94b768)), closes [#402](#402) * added color adjustment feature ([#409](#409)) ([2cbee36](2cbee36)), closes [#380](#380) * added test_repr table tests ([#410](#410)) ([cb77790](cb77790)), closes [#349](#349) * discretize table ([#327](#327)) ([5e3da8d](5e3da8d)), closes [#143](#143) * Improve error handling of TaggedTable ([#450](#450)) ([c5da544](c5da544)), closes [#150](#150) * Maintain tagging in methods inherited from `Table` class ([#332](#332)) ([bc73a6c](bc73a6c)), closes [#58](#58) * new error class `OutOfBoundsError` ([#438](#438)) ([1f37e4a](1f37e4a)), closes [#262](#262) * rename several `Table` methods for consistency ([#445](#445)) ([9954986](9954986)), closes [#439](#439) * suggest similar columns if column gets accessed that doesnt exist ([#385](#385)) ([6a097a4](6a097a4)), closes [#203](#203) ### Bug Fixes * added the missing ids in parameterized tests ([#412](#412)) ([dab6419](dab6419)), closes [#362](#362) * don't warn if `Imputer` transforms column without missing values ([#448](#448)) ([f0cb6a5](f0cb6a5)) * Warnings raised by underlying seaborn and numpy libraries ([#425](#425)) ([c4143af](c4143af)), closes [#357](#357)

lars-reimann · 2023-07-13T22:41:13Z

🎉 This PR is included in version 0.15.0 🎉

The release is available on:

v0.15.0
GitHub release

Your semantic-release bot 📦🚀

patrikguempel added 2 commits July 7, 2023 09:26

added blending feature

bae1550

added gaussian noise

Merge branch 'main' of https://github.com/Safe-DS/Stdlib into 381-add…

a1e35cd

…-gaussian-noise

patrikguempel requested a review from a team as a code owner July 7, 2023 07:30

patrikguempel linked an issue Jul 7, 2023 that may be closed by this pull request

Add gaussian noise #381

Closed

patrikguempel self-assigned this Jul 7, 2023

patrikguempel and others added 5 commits July 7, 2023 09:37

Merge branch 'main' of https://github.com/Safe-DS/Stdlib into 381-add…

b09e8cd

…-gaussian-noise

Merge remote-tracking branch 'origin/381-add-gaussian-noise' into 381…

6b19013

…-add-gaussian-noise

Merge remote-tracking branch 'origin/381-add-gaussian-noise' into 381…

2a2397a

…-add-gaussian-noise

Merge remote-tracking branch 'origin/381-add-gaussian-noise' into 381…

bc8fc48

…-add-gaussian-noise

style: apply automated linter fixes

9cad02c

Marsmaennchen221 changed the title ~~feat: 381 blend & gaussian noise~~ feat: added blend & gaussian noise for Image Jul 7, 2023

patrikguempel and others added 7 commits July 7, 2023 10:15

add ids

6dfdce9

style: apply automated linter fixes

b0f2fed

add ids

e9e4901

Merge remote-tracking branch 'origin/381-add-gaussian-noise' into 381…

97082ee

…-add-gaussian-noise # Conflicts: # tests/safeds/data/image/containers/test_image.py

style: apply automated linter fixes

229d3aa

attempted fix

8724705

Merge remote-tracking branch 'origin/381-add-gaussian-noise' into 381…

524e32d

…-add-gaussian-noise

lars-reimann reviewed Jul 7, 2023

View reviewed changes

src/safeds/data/image/containers/_image.py Outdated Show resolved Hide resolved

lars-reimann reviewed Jul 7, 2023

View reviewed changes

src/safeds/data/image/containers/_image.py Outdated Show resolved Hide resolved

patrikguempel and others added 4 commits July 7, 2023 14:49

Merge branch 'main' into 381-add-gaussian-noise

83b34bd

removed blend feature, fixed greyscale conversion

3fd7d3c

Merge remote-tracking branch 'origin/381-add-gaussian-noise' into 381…

e0a5b3b

…-add-gaussian-noise

style: apply automated linter fixes

4d55f21

lars-reimann changed the title ~~feat: added blend & gaussian noise for Image~~ feat: add gaussian noise for Image Jul 7, 2023

lars-reimann changed the title ~~feat: add gaussian noise for Image~~ feat: add gaussian noise to image Jul 7, 2023

build: add scikit-image

a8bf4bb

lars-reimann force-pushed the 381-add-gaussian-noise branch from f1265c2 to dbba115 Compare July 7, 2023 13:48

megalinter-bot added 2 commits July 12, 2023 11:15

style: apply automated linter fixes

1eb3dae

style: apply automated linter fixes

8884780

Marsmaennchen221 previously approved these changes Jul 12, 2023

View reviewed changes

Merge branch 'main' into 381-add-gaussian-noise

6aaddc8

patrikguempel enabled auto-merge (squash) July 12, 2023 17:12

lars-reimann disabled auto-merge July 12, 2023 19:57

lars-reimann marked this pull request as draft July 12, 2023 19:59

lars-reimann added 2 commits July 12, 2023 22:02

Merge branch 'main' into 381-add-gaussian-noise

0143c35

docs: add new function to Image Processing tutorial

f515c39

lars-reimann dismissed Marsmaennchen221’s stale review via f515c39 July 12, 2023 20:07

lars-reimann marked this pull request as ready for review July 12, 2023 20:23

lars-reimann force-pushed the 381-add-gaussian-noise branch from ff576c5 to 3b79e29 Compare July 12, 2023 20:24

docs: use another picture for the "Image Processing" tutorial

e80d993

lars-reimann force-pushed the 381-add-gaussian-noise branch from 3b79e29 to e80d993 Compare July 12, 2023 20:34

zzril previously approved these changes Jul 12, 2023

View reviewed changes

test: check edge case with standard deviation 0

8006b0d

lars-reimann dismissed zzril’s stale review via 8006b0d July 12, 2023 20:57

zzril approved these changes Jul 12, 2023

View reviewed changes

lars-reimann merged commit 925a505 into main Jul 13, 2023

lars-reimann deleted the 381-add-gaussian-noise branch July 13, 2023 07:13

lars-reimann added the released Included in a release label Jul 13, 2023

Conversation

patrikguempel commented Jul 7, 2023 • edited by lars-reimann Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Uh oh!

github-actions bot commented Jul 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦙 MegaLinter status: ✅ SUCCESS

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zzril commented Jul 12, 2023

Uh oh!

lars-reimann commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lars-reimann commented Jul 12, 2023

Uh oh!

zzril commented Jul 12, 2023

Uh oh!

lars-reimann commented Jul 12, 2023

Uh oh!

zzril commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zzril left a comment

Choose a reason for hiding this comment

Uh oh!

lars-reimann commented Jul 12, 2023

Uh oh!

zzril left a comment

Choose a reason for hiding this comment

Uh oh!

lars-reimann commented Jul 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

patrikguempel commented Jul 7, 2023 •

edited by lars-reimann

Loading

github-actions bot commented Jul 7, 2023 •

edited

Loading

codecov bot commented Jul 7, 2023 •

edited

Loading

lars-reimann commented Jul 12, 2023 •

edited

Loading

zzril commented Jul 12, 2023 •

edited

Loading