feat: add schema conversions when adding new rows to a table and schema conversion when creating a new table#432
Merged
alex-senger merged 66 commits intomainfrom Jul 12, 2023
Merged
Conversation
…e multiple schemas into one feat: Added ability to `Table.add_row` and `Table.add_rows` to allow new rows with different schemas feat: Added the method `Row.sort_columns` to sort the columns in a row
Co-authored-by: alex-senger <91055000+alex-senger@users.noreply.github.com>
…_row-and-add_rows-should-not-raise-if-schemata-differ � Conflicts: � tests/safeds/data/tabular/containers/_table/test_from_rows.py
refactor: Sytisfied the linters Co-authored-by: alex-senger <91055000+alex-senger@users.noreply.github.com>
…alizing-column-or-table
…alizing-column-or-table
…s-when-initializing-column-or-table' into 322-detected-the-true-columntypes-when-initializing-column-or-table # Conflicts: # src/safeds/data/tabular/typing/_column_type.py # tests/safeds/data/tabular/typing/test_column_type.py
…d still get correct schema by Columns with numbers and missing values
Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>
…not-raise-if-schemata-differ' into 404-merge-issues-322-and-127 # Conflicts: # src/safeds/data/tabular/containers/_table.py # tests/safeds/data/tabular/containers/_table/test_add_row.py # tests/safeds/data/tabular/containers/_table/test_add_rows.py
…s-when-initializing-column-or-table' into 404-merge-issues-322-and-127 # Conflicts: # tests/safeds/data/tabular/typing/test_schema.py
Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>
Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>
Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>
Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>
Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>
…ge-issues-322-and-127 # Conflicts: # src/safeds/data/tabular/containers/_column.py # src/safeds/data/tabular/containers/_row.py # src/safeds/data/tabular/containers/_table.py
Contributor
Currently every abstract method we have has a docstring block instead of a |
Marsmaennchen221
requested changes
Jul 11, 2023
Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>
…ge-issues-322-and-127
Contributor
|
It seems like we do not use the import pytest
from safeds.exceptions import SchemaMismatchError
def test_should_raise_schema_mismatch_error() -> None:
with pytest.raises(SchemaMismatchError, match=r"Failed because at least two schemas didn't match."):
raise SchemaMismatchError()@lars-reimann Do we want to keep this error? |
Member
If we don't use it at the moment, let's remove it. We can add it again if we ever need it. |
Marsmaennchen221
requested changes
Jul 11, 2023
Marsmaennchen221
requested changes
Jul 12, 2023
Contributor
Marsmaennchen221
left a comment
There was a problem hiding this comment.
If you accept these changed a Series with Integer and NANs will be considered as an Integer? ColumnType. Before this would be a RealNumber?. With this changes we also convert RealNumber ColumnTypes into Integer ColumnTypes if they have no decimal places (if they end on .0) as we will not loose any information with this convertion
tests/safeds/data/tabular/containers/_column/test_from_pandas_series.py
Outdated
Show resolved
Hide resolved
tests/safeds/data/tabular/containers/_column/test_from_pandas_series.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander <47296670+Marsmaennchen221@users.noreply.github.com>
…ge-issues-322-and-127
Marsmaennchen221
approved these changes
Jul 12, 2023
lars-reimann
pushed a commit
that referenced
this pull request
Jul 13, 2023
## [0.15.0](v0.14.0...v0.15.0) (2023-07-13) ### Features * Add copy method for tables ([#405](#405)) ([72e87f0](72e87f0)), closes [#275](#275) * add gaussian noise to image ([#430](#430)) ([925a505](925a505)), closes [#381](#381) * add schema conversions when adding new rows to a table and schema conversion when creating a new table ([#432](#432)) ([6e9ff69](6e9ff69)), closes [#404](#404) [#322](#322) [#127](#127) [#322](#322) [#127](#127) * add test for empty tables for the method `Table.sort_rows` ([#431](#431)) ([f94b768](f94b768)), closes [#402](#402) * added color adjustment feature ([#409](#409)) ([2cbee36](2cbee36)), closes [#380](#380) * added test_repr table tests ([#410](#410)) ([cb77790](cb77790)), closes [#349](#349) * discretize table ([#327](#327)) ([5e3da8d](5e3da8d)), closes [#143](#143) * Improve error handling of TaggedTable ([#450](#450)) ([c5da544](c5da544)), closes [#150](#150) * Maintain tagging in methods inherited from `Table` class ([#332](#332)) ([bc73a6c](bc73a6c)), closes [#58](#58) * new error class `OutOfBoundsError` ([#438](#438)) ([1f37e4a](1f37e4a)), closes [#262](#262) * rename several `Table` methods for consistency ([#445](#445)) ([9954986](9954986)), closes [#439](#439) * suggest similar columns if column gets accessed that doesnt exist ([#385](#385)) ([6a097a4](6a097a4)), closes [#203](#203) ### Bug Fixes * added the missing ids in parameterized tests ([#412](#412)) ([dab6419](dab6419)), closes [#362](#362) * don't warn if `Imputer` transforms column without missing values ([#448](#448)) ([f0cb6a5](f0cb6a5)) * Warnings raised by underlying seaborn and numpy libraries ([#425](#425)) ([c4143af](c4143af)), closes [#357](#357)
Member
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #404
Closes #322
Closes #127
This Pull request merges the issues #322 and #127.
Summary of Changes